GLX initialization crash [@ mozilla::gl::GLContextGLX::Init ]

RESOLVED FIXED

Status

()

Core
Graphics
--
critical
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(blocking2.0 beta7+)

Details

Attachments

(2 attachments)

Created attachment 477620 [details] [diff] [review]
check for null pointer

This patch fixes this crash reported by Brad on IRC:

###!!! ASSERTION: You can't dereference a NULL nsRefPtr with operator->().: 'mRawPtr != 0', file ../../dist/include/nsAutoPtr.h, line 1117
 
Program received signal SIGSEGV, Segmentation fault.
0x00007ffff665dc22 in mozilla::gl::GLContextGLX::Init (this=0x0) at ../../../gfx/thebes/GLContextProviderGLX.cpp:247
247             MakeCurrent();
(gdb) bt
#0  0x00007ffff665dc22 in mozilla::gl::GLContextGLX::Init (this=0x0) at ../../../gfx/thebes/GLContextProviderGLX.cpp:247
#1  0x00007ffff665d28f in mozilla::gl::GLContextProviderGLX::CreateForNativePixmapSurface (aSurface=0x7fffc9437380)
    at ../../../gfx/thebes/GLContextProviderGLX.cpp:713
#2  0x00007ffff6674ccd in mozilla::layers::CairoImageOGL::SetData (this=0x7fffd26523c0, aData=...)
    at ../../../gfx/layers/opengl/ImageLayerOGL.cpp:685
#3  0x00007ffff51a8828 in nsPluginInstanceOwner::SetCurrentImage (this=0x7fffcaa0c900, aContainer=0x7fffd2652300)
    at ../../../layout/generic/nsObjectFrame.cpp:1690
#4  0x00007ffff51a8cf6 in nsObjectFrame::BuildLayer (this=0x7fffda73db30, aBuilder=0x7fffffffc020, aManager=0x7fffd99337c0,
    aItem=0x7fffdd37d878) at ../../../layout/generic/nsObjectFrame.cpp:1753
#5  0x00007ffff51b422a in nsDisplayPlugin::BuildLayer (this=0x7fffdd37d878, aBuilder=0x7fffffffc020, aManager=0x7fffd99337c0)
    at ../../../layout/generic/nsObjectFrame.h:339
Attachment #477620 - Flags: review?(matt.woodrow+bugzilla)
Summary: Fix a GLX initialization crash → GLX initialization crash [@ mozilla::gl::GLContextGLX::Init ]
Attachment #477620 - Flags: review?(matt.woodrow+bugzilla) → review+
GLContextGLX::CreateGLContext calls Init for us already, so we can drop that part.

Updated

7 years ago
Severity: normal → critical
Version: unspecified → Trunk
(Assignee)

Comment 2

7 years ago
Created attachment 478046 [details] [diff] [review]
remove bad Init() call
Assignee: nobody → bjacob
Status: NEW → ASSIGNED
Attachment #478046 - Flags: review+
(Assignee)

Comment 3

7 years ago
(carried forward r+)
Blocking because this is a crash when we create a WebGL context on desktop linux.
blocking2.0: --- → beta7+
(Assignee)

Comment 5

7 years ago
http://hg.mozilla.org/mozilla-central/rev/469871adcd24
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.