598800 - Server needs to do proportional allocation to nodes

Status: RESOLVED FIXED

(Cloud Services :: Server: Registration, defect)

Description

[Toby Elliott [:telliott]]

With the introduction of different-capacity servers, we need to assign to nodes based on a proportion of expected maximum.

Comment 1

[Toby Elliott [:telliott]]

I think this is actually easier than I expected. Instead of ordering by actives, we order by actives/max_capacity.

If this turns out to be too inefficient (shouldn't be with only a couple hundred rows), we can have the nightly actives update add % to a new column and order by that.

This doesn't address how we get max_capacity into available_nodes (and mandates that max_capacity is now NOT NULL). We probably need to add it to the master config file for each node.

Comment 3

[Toby Elliott [:telliott]]

Attachment: Uses max_capacity and downed status to pick a node

This requires the changes in 599133 or things will break horribly

Comment 4

[Toby Elliott [:telliott]]

In http://hg.mozilla.org/services/reg-server/rev/45868518b54a

Comment 5

[Toby Elliott [:telliott]]

Also need to do this to sreg

Comment 6

[Toby Elliott [:telliott]]

Attachment: Uses the reg algorithm to assign nodes

changes the select over to the reg version. Also appears to have removed a bunch of spaces.

Comment 7

[JR Conlin [:jrconlin,:jconlin]]

Comment on attachment 520900 [details] [diff] [review]
Uses the reg algorithm to assign nodes

Wow. loads of whitespace diffs.

Comment 8

[Tarek Ziadé (:tarek)]

Why this is REOPENED ?