598853 - Fix "assignment to undeclared variable" warning in test-manifest

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Drew Willcoxon :adw]

Attachment: patch

Running `cfx test` generates this warning:

  console: [JavaScript Warning: "assignment to undeclared variable warnings" {file: "file:///Users/adw/jetpack-sdk/packages/jetpack-core/lib/securable-module.js -> resource://jetpack-core-jetpack-core-lib/securable-module.js -> resource://jetpack-core-jetpack-core-tests/test-manifest.js" line: 55}]

Which causes this to be emitted at the very end of the output:

  warning: 1 warnings or errors were logged to the platform's nsIConsoleService, which could be of no consequence; however, they could also be indicative of aberrant behavior.

Easy fix!  The `warnings` variable is undeclared.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 477858 [details] [diff] [review]
patch

Excellent! r+a=myk

Comment 2

[Drew Willcoxon :adw]

http://hg.mozilla.org/labs/jetpack-sdk/rev/7d01e428b30f

Comment 3

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".