Closed Bug 598854 Opened 9 years ago Closed 9 years ago

Simplify code now that we don't paint non-displayroot widgets

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: roc, Assigned: roc)

References

Details

(Whiteboard: not-ready)

Attachments

(1 file)

Thanks to bug 596414, we no longer paint into any widget whose view/frame is not a displayroot. So we can remove all the code that handles that case.
Attached patch fixSplinter Review
Attachment #477860 - Flags: review?(tnikkel)
Attachment #477860 - Flags: review?(tnikkel) → review+
Comment on attachment 477860 [details] [diff] [review]
fix

Straightforward code simplification. Takes out a bad slow path that we never currently hit, and we want to be sure we never do hit.
Attachment #477860 - Flags: approval2.0?
Attachment #477860 - Flags: approval2.0? → approval2.0+
Whiteboard: [needs landing]
This changes nsIViewObserver so to avoid any possible compat issues I'll land this post-2.0.
Whiteboard: [needs landing] → [needs landing post-2.0]
Depends on: post2.0
Attachment #477860 - Flags: approval2.0+ → approval2.0-
Whiteboard: [needs landing post-2.0] → [needs landing]
This doesn't apply cleanly on trunk any more.
Whiteboard: [needs landing] → not-ready
http://hg.mozilla.org/mozilla-central/rev/5e2217f80868
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Depends on: 653994
You need to log in before you can comment on or make changes to this bug.