598864 - Tracking: Composite shadow layers with GL

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

10,000-foot view of plan is
 - have LayerManagerOGL implement ShadowLayerManager
 - create a ForeignTextureImage, or normal TextureImage, for shadow layers
 - upload repainted content to texture

We need
 - ability to swap out Pixmaps when using texture-from-pixmap, should be easy
 - fast way to upload nsRegions to texture ... easiest is to create scratch ImageSurface, glTexSubImage2D that
 - maybe exotic, fast EGLImage-y stream-y things where available?
 - shaders optimized for SGX

Lots of unknowns and tests to run.  Parts of the above may have been obsoleted by recent GL layers work.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Joe pointed me at http://www.dei.isep.ipp.pt/~matos/cg/docs/manual/glPixelStore.3G.html, specifically GL_UNPACK_ROW_LENGTH.  Using this plus existing Shmem rendering looks like an easy first implementation.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Chris, we try not to block on meta bugs. Can you please request blocking-fennec on all appropriate sub-bugs.

Comment 3

[Oleg Romashin (:romaxa)]

>  - ability to swap out Pixmaps when using texture-from-pixmap, should be easy
For this we should keep ShadowLayer parent as X-Surface, and child as Image surface, Bind Parent X-Surface to Texture, and instead of swap do XShmPutImage

>  - fast way to upload nsRegions to texture ... easiest is to create scratch
> ImageSurface, glTexSubImage2D that

Somehow this glTexSubImage2D - optimized on maemo6 (not 100% sure)

>  - maybe exotic, fast EGLImage-y stream-y things where available?
We have nice extension which allow us to lock texture and get raw pointer to memory shared to GPU (recent egl lock extension).
that allow us avoid XShmPutImage and just do memcpy locally, or paint directly to Texture memory buffer

>  - shaders optimized for SGX
Bug 572651 - is first things we need to fix

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #3)
> >  - maybe exotic, fast EGLImage-y stream-y things where available?
> We have nice extension which allow us to lock texture and get raw pointer to
> memory shared to GPU (recent egl lock extension).
> that allow us avoid XShmPutImage and just do memcpy locally, or paint directly
> to Texture memory buffer

This would work well -- we already have the TextureImage abstraction, so have a natural place to lock/unlock.  Can you point us at the docs for the extension?

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Tracking bug doesn't block.