Closed
Bug 59887
Opened 24 years ago
Closed 15 years ago
Focus ring for three-pane window has bad color
Categories
(SeaMonkey :: MailNews: Message Display, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mpt, Unassigned)
References
Details
(Keywords: polish)
Attachments
(1 file)
702 bytes,
patch
|
shliang
:
review+
hewitt
:
superreview+
|
Details | Diff | Splinter Review |
Build: 2000111108, Mac OS 9.0 The focus ring to indicate which pane has focus in the three-pane window is black and two pixels thick (or three pixels when the black outline for the pane itself is included), making the window look rather oafish. The focus ring should be in the variation color (which in Windows is the same as the selection highlight color, e.g. dark blue), and should be only one pixel thick inside the black pane outline.
Reporter | ||
Updated•24 years ago
|
Comment 1•24 years ago
|
||
46174 has a patch which ads the Mac OS variation colours to CSS. I'll clean it up and get it checked in once someone checks in my patch on bug 1004 (which the 46174 patch is based on). 1004 is reviewed and super reviewed - just waiting for someone to check it in...
Depends on: 46174
Comment 2•23 years ago
|
||
See also edge-of-screen bugs: bug 66633, bug 66632. Would it make sense for the borders to be inside their respective trees and transparent to clicks?
Reporter | ||
Comment 3•23 years ago
|
||
See also bug 60336, where the three-pane scrollbars have bad alignment in order to make room for the focus ring. > Would it make sense for the borders to be inside their respective trees and > transparent to clicks? Yes. For that reason, this bug may depend on whatever magic is used to fix bug 42758.
Comment 4•23 years ago
|
||
reassigning to andreww who I think did this originally.
Assignee: putterman → andreww
border is already reduced. Now the color matches the Mac's focusring color - from the system. Patch ready for review, super review.
Keywords: review
Comment on attachment 56212 [details] [diff] [review] changes to mailwindow1.css r=shliang
Attachment #56212 -
Flags: review+
Updated•23 years ago
|
Attachment #56212 -
Flags: superreview+
Comment 8•23 years ago
|
||
Comment on attachment 56212 [details] [diff] [review] changes to mailwindow1.css sr=hewitt
Updated•23 years ago
|
QA Contact: nbaca → olgam
fix checked into trunk
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 10•23 years ago
|
||
I see focus ring only on Thread pane. OK, since we have a separate bug 109193 for invisible focus ring, I verify this one - on Mac OSX.
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 11•22 years ago
|
||
Reproduced in build 2002060508, Mac OS 9.2.2. Reopening. As Andrew said in comment 6, the ring is 1px thick as expected, but it's still black when it should be the variation color.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Summary: Focus ring for three-pane window has bad color/width → Focus ring for three-pane window has bad color
Updated•22 years ago
|
Target Milestone: mozilla0.9.6 → ---
Comment 12•21 years ago
|
||
Is this bug Mac classic only? If yes, it should be WONTFIX'ed. if not it should be moved over to Mac OS X.
Updated•20 years ago
|
Product: Browser → Seamonkey
Updated•16 years ago
|
Assignee: andreww → mail
Status: ASSIGNED → NEW
Priority: P3 → --
QA Contact: olgam
Comment 14•15 years ago
|
||
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state. If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way. If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar). If no action happens within the next few months, we move this bug report to an EXPIRED state. Query tag for this change: mass-UNCONFIRM-20090614
Status: NEW → UNCONFIRMED
Comment 15•15 years ago
|
||
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state. If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way. If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar). If no action happens within the next few months, we move this bug report to an EXPIRED state. Query tag for this change: mass-UNCONFIRM-20090614
Comment 16•15 years ago
|
||
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state. If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way. If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar). If no action happens within the next few months, we move this bug report to an EXPIRED state. Query tag for this change: mass-UNCONFIRM-20090614
Comment 17•15 years ago
|
||
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state. If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way. If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar). If no action happens within the next few months, we move this bug report to an EXPIRED state. Query tag for this change: mass-UNCONFIRM-20090614
Comment 18•15 years ago
|
||
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state. If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way. If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar). If no action happens within the next few months, we move this bug report to an EXPIRED state. Query tag for this change: mass-UNCONFIRM-20090614
Comment 19•15 years ago
|
||
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state. If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way. If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar). If no action happens within the next few months, we move this bug report to an EXPIRED state. Query tag for this change: mass-UNCONFIRM-20090614
Comment 21•15 years ago
|
||
This is fixed by the patch in bug 460699. I see that the windows focus ring is still black, but since winstripe's tree focus ring is black, I guess it's ok.
Status: NEW → RESOLVED
Closed: 23 years ago → 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•