Random interned string constants should all move into AvmCore

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: lhansen, Assigned: lhansen)

Tracking

(Blocks: 1 bug)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
There are some on RegExpClass ("index", "input"), many more on XMLClass, and scattered ones throughout the code base.  They create arbitrary clutter - if the VM needs them we should instantiate them on startup (because they will be instantiated anyway), and we can optimize bulk instantiation better in one location if that's something we're interested in doing.
(Assignee)

Updated

8 years ago
Blocks: 576307
(Assignee)

Comment 1

8 years ago
Created attachment 477890 [details] [diff] [review]
Obvious patch

Leaves the one identified in bug #598904 alone but moves everything else into AvmCore.
Attachment #477890 - Flags: review?(edwsmith)

Updated

8 years ago
Attachment #477890 - Flags: review?(edwsmith) → review+
(Assignee)

Comment 2

8 years ago
tamarin-redux changeset:   5246:b28f6ad69a91
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.