598909 - change request module to use EventEmitter event registration model

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Implements changes

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 477899 [details] [diff] [review]
Implements changes

>diff --git a/packages/jetpack-core/docs/request.md b/packages/jetpack-core/docs/request.md

>-    terms of XHR, when `readyState == 4`. The request object is available as
>-    `this` inside the callback. So in order to use the response, you'll need to
>-    access `this.response`
>+    terms of XHR, when `readyState == 4`. The `responce` & `request` objects
>+    are passed to the callback as an arguments.

Nit: responce -> response


>diff --git a/packages/jetpack-core/tests/test-request.js b/packages/jetpack-core/tests/test-request.js

Nit: it would be useful to have at least one test that tests that request.response == response inside a "complete" handler.

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

fixed by changeset https://hg.mozilla.org/labs/jetpack-sdk/rev/0c5f1b013c57

Comment 4

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".