If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Select image dialog has wrong title

VERIFIED FIXED in mozilla0.9

Status

()

Core
Editor
P3
trivial
VERIFIED FIXED
17 years ago
16 years ago

People

(Reporter: Reinout van Schouwen, Assigned: Charles Manske)

Tracking

Trunk
mozilla0.9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: CMVC32946)

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
The Image dialog of Composer has a button to choose a file to import. The title
of this dialog is 'Open HTML File', where instead it should be 'Choose image file'.

A weird thing which is probably specific to OS/2 is that this file chooser
dialog is a lot prettier than the default one you get with File > Open File in
the Navigator window!

Comment 1

17 years ago
Created attachment 19174 [details] [diff] [review]
Using wrong property string

Comment 2

17 years ago
This is an XP problem - fix attached
Assignee: mkaply → beppe
Status: UNCONFIRMED → NEW
Component: Compositor → Editor
Ever confirmed: true
Keywords: patch, review
OS: OS/2 → All
QA Contact: petersen → sujay

Comment 3

17 years ago
adding cc

Updated

17 years ago
Whiteboard: CMVC32946

Comment 4

17 years ago
r=timeless
Keywords: approval

Comment 5

17 years ago
sf=sfraser
Assignee: beppe → cmanske
(Assignee)

Comment 6

17 years ago
This applies to all OS versions. Suggested patch is not entirely correct -- I'll
attach a better fix.
Status: NEW → ASSIGNED
Summary: OS/2 - Import image dialog has wrong title → Select image dialog has wrong title
Target Milestone: --- → mozilla0.9
(Assignee)

Comment 7

17 years ago
Created attachment 19406 [details] [diff] [review]
Sets the correct file picker caption for both Image and HTML files
(Assignee)

Comment 8

17 years ago
Can anyone please review the new fix?

Comment 9

17 years ago
timeless, could you r= the new fix please?

Thanks

Comment 10

17 years ago
r=timeless
Hardware: PC → All

Comment 11

17 years ago
sr=sfraser again

Comment 12

17 years ago
Fix checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 13

17 years ago
verified in 1/17 build...

it now says "Select Image File"
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.