598962 - [TEST] browser_preferences_basic panning is busted

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/mobile/chrome/browser_preferences_basic.js | Preferences pane is panned down - Got 0 113, expected 0,0

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

this is still a problem with a fresh build from today.

Comment 2

[Matt Brubeck (:mbrubeck)]

I wonder if kinetic panning from the first drag is interfering with the second drag.

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This is broken because MouseModule.prototype._onMouseMove does not cause a drag to happen while waiting for an animation frame ("_waitingForPaint").  Fixed this by making the test wait for the MozBeforePaint event before doing its second drag.

I changed the two vertical drags into a single up-then-down drag, so that kinetic panning would not break the test.

Also moved the left/right panning (which is expected to do nothing) above the up/down panning, so that we don't have to wait for MozBeforePaint more than once.

Also fixed an unrelated bug that caused extra tabs to be left open in this test, and the same bug in another test.

Cleaned up some unused code and comment spelling in browser_preferences_text.js while I was at it.

Finally, after making these changes, for reasons I do not understand, browser_tabs.js was leaving the right sidebar visible and causing browser_tapping.js to fail.  Added a hideSidebars() call as a dumb workaround.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 480260 [details] [diff] [review]
patch

You know, I think we need to make some rules about finishing a test:
* Sidebars are not open, unless the test opened them on purpose
* No URLBar showing, unless the test opened it
* Close any tabs opened during the test
* If a sidebar or URLbar is visible, but should not be - it's an error!

We could add the checks to the finish part of the test for the tests that follow that pattern. But all tests have somewhere we could put the checks. The checks could be impled in head.js and just call the function in the test itself

Comment 5

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mobile-browser/rev/e54e94fd67d1