598965 - Awesome screen can still be panned once the context menu is shown

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This is a little regression from the big changes happened into inputhandler this night but still a small bug compare to the diff :)

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 477947 [details] [diff] [review]
Patch

>+      case "contextmenu":
>+        if (ContextHelper.popupState)
>+          this.cancelPending();
>+        break;

Add a comment in the case block so we know why this code is there, and hopefully it won't be removed without testing for this case. Maybe even point to this bug.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Vivien - Please land this for beta 1

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/5237ea6ffe6d

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b6pre) Gecko/20100924 Namoroka/4.0b7pre Fennec/2.0b1pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b6pre) Gecko/20100924 Namoroka/4.0b7pre Fennec/2.0b1pre


There's a follow-up bug here: https://bugzilla.mozilla.org/show_bug.cgi?id=599362

Comment 6

[Dão Gottwald [:dao]]

bugspam