Idle service should invoke components registered in a idle-daily category

RESOLVED FIXED in mozilla2.0b7

Status

()

Core
Widget
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

Trunk
mozilla2.0b7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Ts])

Attachments

(1 attachment, 1 obsolete attachment)

2.92 KB, patch
roc
: review+
Joe Drew (not getting mail)
: approval2.0+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
Various services just need to do their work in idle-daily. To accomplish the task we have to init the component, then register for idle-daily, then wait to be called.

It would be better (also from a startup perf point of view) if idle service could init those components by itself before notifying, through a category cache.
(Assignee)

Comment 1

8 years ago
I'll try to bring this out because I want it for bug 541373 and is a possible help for startup time.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
(Assignee)

Updated

8 years ago
Whiteboard: [Ts]
(Assignee)

Comment 2

8 years ago
Created attachment 481063 [details] [diff] [review]
patch v1.0

The patch is pretty small, maybe too small! Unfortunately I have no idea how I could test this stuff, I can't force a system idle, or at least I think so.

Will test manually reducing some timeout.
(Assignee)

Updated

8 years ago
Depends on: 602085
(Assignee)

Comment 3

8 years ago
Created attachment 481493 [details] [diff] [review]
patch v1.1

applies on top of bug 602085, thus it's even smaller than 1.0!

tested manually with my patch in bug 570387
Attachment #481063 - Attachment is obsolete: true
Attachment #481493 - Flags: review?(sdwilsh)
(Assignee)

Comment 4

8 years ago
Comment on attachment 481493 [details] [diff] [review]
patch v1.1

moving review to roc, since Shawn will be away for some days and is unlikely to find time soon
Attachment #481493 - Flags: review?(sdwilsh) → review?(roc)
(Assignee)

Comment 5

8 years ago
Comment on attachment 481493 [details] [diff] [review]
patch v1.1

Thanks!

This needs approval, it's nice to have to avoid useless work at startup
Attachment #481493 - Flags: approval2.0?
Attachment #481493 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 6

8 years ago
http://hg.mozilla.org/mozilla-central/rev/d001a53858f0
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.