599092 - buildbot log html-formatting not href'ing aggressively enough

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Build Config, enhancement, P4)

Description

[Felix S. Klock II [:pnkfelix, :fklock]]

Consider a log like (sorry if link is insufficiently persistent):

http://tamarin-builds.mozilla.org/tamarin-redux/builders/linux-arm-smoke-sandbox/builds/224/steps/SmokeTest/logs/stdio

Note that the file starts off with a href link that says "(view as text)", so you can go to the original log if you don't want the html formatting.  Note also that this stdio log is what buildbot links to in its emailed failure messages.

Now, given that, this is silly:

  Build log can be found here: http://asteam.macromedia.com/builds/sandbox/5417-43983c8d6c35/linux/smokes-linux-arm.log
  url: http://asteam.macromedia.com/builds/sandbox/5417-43983c8d6c35/linux/smokes-linux-arm.log build log

That is, the exact same text for a url is being presented twice in a row, but neither one is rendered as a href that I can directly click.

Comment 1

[Felix S. Klock II [:pnkfelix, :fklock]]

Isn't fixing this just putting in something like the diff below?

(I'm not posting as a patch attachment because I don't actually know which directory the modification needs to go into.)

Also note that the "(view as text)" version would remain unchanged, in case we were worried about the below regexp mucking with things.

diff --git a/buildbot/src/buildbot-0.7.10p1/buildbot/status/web/logs.py b/buildbot/src/buildbot-0.7.10p1/buildbot/status/web/logs.py
--- a/buildbot/src/buildbot-0.7.10p1/buildbot/status/web/logs.py
+++ b/buildbot/src/buildbot-0.7.10p1/buildbot/status/web/logs.py
@@ -87,18 +87,22 @@ class TextLog(Resource):
         for type, entry in entries:
             if type >= len(builder.ChunkTypes) or type < 0:
                 # non-std channel, don't display
                 continue
             if self.asText:
                 if type != builder.HEADER:
                     data += entry
             else:
+                escapedEntry = html.escape(entry)
+                addHrefEntry = re.sub(r'(http://\S*)',
+                                      r'<a href="\1">\1</a>',
+                                      escapedEntry);
                 data += spanfmt % (builder.ChunkTypes[type],
-                                   html.escape(entry))
+                                   addHrefEntry)
         return data
 
     def htmlFooter(self):
         data = "</pre>\n"
         data += "</body></html>\n"
         return data
 
     def render_HEAD(self, request):

Comment 2

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Tamarin is a dead project now. Mass WONTFIX.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Tamarin isn't maintained anymore. WONTFIX remaining bugs.