599101 - Fix EGL crash: mEGLLibrary was not loaded on non-Windows, depending on uninitialized value

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: fix EGL crasher

Look at this code:

#ifdef XP_WIN
       // .............

            angleFile->Append(NS_LITERAL_STRING("libEGL.dll"));
            angleFile->Load(&mEGLLibrary);
        } while (false);
#endif

        if (!mEGLLibrary) {
            mEGLLibrary = PR_LoadLibrary(EGL_LIB);
            if (!mEGLLibrary) {
                NS_WARNING("Couldn't load EGL LIB.");
                return PR_FALSE;
            }
        }





The problem there was that mEGLLibrary was uninitialized, so when it was accidentally non-null, we failed to load EGL, giving Brad a SIGILL.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: fix EGL crasher

oops, typo

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/mozilla-central/rev/6a603e96b8fe