Closed Bug 599193 Opened 12 years ago Closed 11 years ago

Test failure in test_utils_file.js: NS_ERROR_FAILURE [nsIFile.remove]

Categories

(Firefox :: Sync, defect)

Product:
Firefox
Component:
Sync
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: philikon, Assigned: philikon)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

v1
4.06 KB, patch
mconnor
: review+
Details | Diff | Splinter Review 
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1285282431.1285284398.17722.gz&fulltext=1
WINNT 5.2 mozilla-central debug test xpcshell on 2010/09/23 15:53:51
s: win32-slave36

TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\xpcshell\tests\services\sync\tests\unit\test_utils_file.js | test failed (with xpcshell return code: 0), see following log:
  >>>>>>>
  ### XPCOM_MEM_LEAK_LOG defined -- logging leaks to c:\docume~1\cltbld\locals~1\temp\tmph7_uiz\runxpcshelltests_leaks.log
pldhash: for the table at address 063210C0, the given entrySize of 48 probably favors chaining over double hashing.
nsNativeModuleLoader::LoadModule("e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\firefox\components\xpcomsample.dll") - load FAILED, rv: 80520012, error:
	<unknown; can't get error from NSPR>
WARNING: This method is lossy. Use GetCanonicalPath !: file e:/builds/moz2_slave/mozilla-central-win32-debug/build/xpcom/io/nsLocalFileWin.cpp, line 2977
pldhash: for the table at address 07149A98, the given entrySize of 52 probably favors chaining over double hashing.
Setting the identity for passphrase
Test file-related utility functions
TEST-INFO | (xpcshell/head.js) | test 1 pending
getTmp with no argument
TEST-PASS | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test_utils_file.js | [_test_getTmp : 27] true == true
TEST-PASS | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test_utils_file.js | [_test_getTmp : 28] true == true
TEST-PASS | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test_utils_file.js | [_test_getTmp : 29] true == true
TEST-PASS | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test_utils_file.js | [_test_getTmp : 30] tmp == tmp
getTmp with a string
TEST-PASS | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test_utils_file.js | [_test_getTmp : 37] true == true
TEST-PASS | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test_utils_file.js | [_test_getTmp : 38] true == true
TEST-PASS | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test_utils_file.js | [_test_getTmp : 39] name == name
TEST-PASS | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test_utils_file.js | [_test_getTmp : 40] true == true
Open for reading, providing a file
TEST-PASS | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test_utils_file.js | [_test_open : 63] c:\docume~1\cltbld\locals~1\temp\tmph7_uiz\weave\tmp\_test_ == c:\docume~1\cltbld\locals~1\temp\tmph7_uiz\weave\tmp\_test_
TEST-PASS | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test_utils_file.js | [_test_open : 64] true == true
TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIFile.remove]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test_utils_file.js :: _test_open :: line 65"  data: no]
WARNING: nsExceptionService ignoring thread destruction after shutdown: file e:/builds/moz2_slave/mozilla-central-win32-debug/build/xpcom/base/nsExceptionService.cpp, line 197
nsXPConnect::CommenceShutdown()
WARNING: OOPDeinit() without successful OOPInit(): file e:/builds/moz2_slave/mozilla-central-win32-debug/build/toolkit/crashreporter/nsExceptionHandler.cpp, line 1582
nsStringStats
 => mAllocCount:           2030
 => mReallocCount:           84
 => mFreeCount:            2030
 => mShareCount:           7101
 => mAdoptCount:            153
 => mAdoptFreeCount:        153

  <<<<<<<
Disabled tests for now: http://hg.mozilla.org/mozilla-central/rev/59b25e24dc5e

sdwilsh says we need to do something like this to make Windows happy: http://mxr.mozilla.org/mozilla-central/source/storage/test/unit/head_storage.js#71
Attached patch v1 — — Splinter Review 
Pushed to try just now to see if this fixes the orange.
Assignee: nobody → philipp
Attachment #478128 - Flags: review?(mconnor)
Blocks: 438871
Whiteboard: [orange]
Still getting a failure with patch v1:

TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\tryserver-win32-debug-unittest-xpcshell\build\xpcshell\tests\services\sync\tests\unit\test_utils_file.js | test failed (with xpcshell return code: 0), see following log:  >>>>>>>  ### XPCOM_MEM_LEAK_LOG defined -- logging leaks to c:\docume~1\cltbld\locals~1\temp\tmplgufsq\runxpcshelltests_leaks.log
pldhash: for the table at address 06541420, the given entrySize of 48 probably favors chaining over double hashing.nsNativeModuleLoader::LoadModule("e:\builds\moz2_slave\tryserver-win32-debug-unittest-xpcshell\build\firefox\components\xpc
omsample.dll") - load FAILED, rv: 80520012, error:
        <unknown; can't get error from NSPR>WARNING: This method is lossy. Use GetCanonicalPath !: file e:/builds/moz2_slave/tryserver-win32-debug/build/xpcom/io/nsLoc
alFileWin.cpp, line 2977
pldhash: for the table at address 07577210, the given entrySize of 52 probably favors chaining over double hashing.
Setting the identity for passphrase
Test file-related utility functions
TEST-INFO | (xpcshell/head.js) | test 1 pending
getTmp with no argument
TEST-PASS | e:/builds/moz2_slave/tryserver-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test
_utils_file.js | [_test_getTmp : 27] true == true
TEST-PASS | e:/builds/moz2_slave/tryserver-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test
_utils_file.js | [_test_getTmp : 28] true == trueTEST-PASS | e:/builds/moz2_slave/tryserver-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test
_utils_file.js | [_test_getTmp : 29] true == trueTEST-PASS | e:/builds/moz2_slave/tryserver-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test
_utils_file.js | [_test_getTmp : 30] tmp == tmpgetTmp with a string
TEST-PASS | e:/builds/moz2_slave/tryserver-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test_utils_file.js | [_test_getTmp : 37] true == true
TEST-PASS | e:/builds/moz2_slave/tryserver-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test_utils_file.js | [_test_getTmp : 38] true == true
TEST-PASS | e:/builds/moz2_slave/tryserver-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test_utils_file.js | [_test_getTmp : 39] name == name
TEST-PASS | e:/builds/moz2_slave/tryserver-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test_utils_file.js | [_test_getTmp : 40] true == true
Open for reading, providing a fileTEST-PASS | e:/builds/moz2_slave/tryserver-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test
_utils_file.js | [_test_open : 63] c:\docume~1\cltbld\locals~1\temp\tmplgufsq\weave\tmp\_test_ == c:\docume~1\cltbld\locals~1\temp\tmplgufsq\weave\tmp\_test_
TEST-PASS | e:/builds/moz2_slave/tryserver-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test_utils_file.js | [_test_open : 64] true == true
Open for reading, providing a file nameTEST-UNEXPECTED-FAIL | (xpcshell/head.js) | [Exception... "Component returned failure code: 0x80520008 (NS_ERROR_FILE_ALREA
DY_EXISTS) [nsIFile.create]"  nsresult: "0x80520008 (NS_ERROR_FILE_ALREADY_EXISTS)"  location: "JS frame :: e:/builds/moz2_slave/tryserver-win32-debug-unittest-xpcshell/build/xpcshell/tests/services/sync/tests/unit/test_utils_file.js :: createFil
e :: line 50"  data: no]WARNING: nsExceptionService ignoring thread destruction after shutdown: file e:/builds/moz2_slave/tryserver-win32-debug/bui
ld/xpcom/base/nsExceptionService.cpp, line 197nsXPConnect::CommenceShutdown()
WARNING: OOPDeinit() without successful OOPInit(): file e:/builds/moz2_slave/tryserver-win32-debug/build/toolkit/crashreporter/nsExceptionHandler.cpp, line 1582
nsStringStats
 => mAllocCount:           2033 => mReallocCount:           75
 => mFreeCount:            2033 => mShareCount:           7105
 => mAdoptCount:            153
 => mAdoptFreeCount:        153

  <<<<<<<

See http://stage.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/pweitershausen@mozilla.com-8112acb2683f/tryserver-win32-debug/tryserver-win32-debug-unittest-xpcshell-build213.txt.gz

Not sure what the first TEST-UNEXPECTED-FAIL is about, for the second one we actually should change the test to choose a random file name to avoid clashes if the temp file exists.
Comment on attachment 478128 [details] [diff] [review]
v1

Maybe it's worth this being a helper instead of having to duplicate the try/catch + comment everywhere?
Attachment #478128 - Flags: review?(mconnor) → review+
(In reply to comment #8)
> Maybe it's worth this being a helper instead of having to duplicate the
> try/catch + comment everywhere?

Yeah, I was aiming for a quick fix here (search + replace). As I noted in comment 5, there are still some failures even with patch v1, so I'll have to revisit this anyway.
This test was removed as part of bug 648338.
Status: NEW → RESOLVED
Closed: 11 years ago
Depends on: 648338
Resolution: --- → FIXED
Whiteboard: [orange]
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.