599198 - Content process throws several catastrophic assertions while initializing XPCOM

Status: VERIFIED FIXED

(Core :: XPCOM, defect)

Description

[Josh Matthews [:jdm]]

Attachment: Assertion backtrace

In summary, nsIXPCComponents is never registered, a fact which throws nsXPConnect::InitClasses for a loop which in turn breaks nsContentUtils initialization.  This only happens on MacOS because of the non-flat directory structure - that is, plugin-container attempts to initialize XPCOM from its local directory (FennecDebug.app/Contents/MacOS/plugin-container.app/Contents/MacOS/) which is empty.  On other platforms, plugin-container and fennec reside in dist/bin together, so component registration Just Works.

Comment 1

[Josh Matthews [:jdm]]

Attachment: Workaround to allow Fennec to run on MacOS

Running with this patch results in a working desktop Fennec build.

Comment 2

[Josh Matthews [:jdm]]

As the --enable-ipc switch has just been flipped for Fennec on mac, this just became a bigger issue as nightly builds are now useless.  Benjamin, should we focus on resolving these issues and check in this patch as a stopgap, or just pull the plug on any effort to make desktop mac builds usable?

Comment 3

[Benjamin Smedberg]

You think this patch is a stopgap? Why not a permanent solution? I really don't think this is a blocker for anything, but if we have a patch let's get it landed.

Comment 4

[Benjamin Smedberg]

Comment on attachment 478125 [details] [diff] [review]
Workaround to allow Fennec to run on MacOS

I really don't like the fact that you're QIing twice. With an extra nsCOMPtr<nsIFile> you can do GetParent/GetParent/QI instead of GetParent/QI/GetParent/QI.

But in any case, this looks like a fine solution.

Comment 6

[Aakash Desai [:aakashd]]

Assigning to dougt per his request.

Comment 7

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/10a6b2c105ae

jdm, you want to file a follow up?

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Calling a macro without an argument like in |NS_ENSURE_TRUE(localFile,)| is non-standard and will cause warnings. Please expand them...

Comment 9

[Aakash Desai [:aakashd]]

verified FIXED on build:

Build identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X; rv:2.0b7pre) Gecko/10201005 Firefox/4.0b7pre Fennec/4.0b1

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

found that nightly is not working, but the beta 1 rc3 is.  reported Bug 602539