599226 - page-mod should log exceptions with console.exception, not roll its own logger

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Drew Willcoxon :adw]

Attachment: patch

page-mod logs exceptions with console.error in a weird format that's not consistent with the rest of Jetpack.  For example, when a content script has an undefined var, this is logged:

error: XXXadw is not defined /Users/adw/jetpack-sdk/packages/page-mod-canvas/data/content-script.js 12 @/Users/adw/jetpack-sdk/packages/page-mod-canvas/data/content-script.js:12

Instead, this should be logged, which is what happens if the exception is passed to console.exception:

error: An exception occurred.
Traceback (most recent call last):
  File "/Users/adw/jetpack-sdk/packages/page-mod-canvas/data/content-script.js", line 12, in 
ReferenceError: XXXadw is not defined

Comment 1

[Drew Willcoxon :adw]

That first error is actually all on one line.

Comment 2

[Drew Willcoxon :adw]

http://hg.mozilla.org/labs/jetpack-sdk/rev/a2dc275b8227

Comment 3

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".