599241 - Draw accent colour in titlebar until we can draw content in titlebar again

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Joe Drew (not getting mail)]

Attachment: draw accent colour in the titlebar

It's quite a bit of work to get drawing of the persona in the titlebar working with OpenGL, but it's much less work to get the accent colour drawing in the titlebar again. This patch does that.

Comment 1

[Markus Stange [:mstange]]

The LightweightThemeConsumer.jsm part is good, the nsChildView.mm is unnecessary if you land bug 595933 first, and I'm not happy with the nsCocoaWindow.mm part.
I think you only need to change this:

> CGPatternDrawPatternCallback cb = [mWindow drawsContentsIntoWindowFrame] ?
>                                     &ContentPatternDrawCallback : &RepeatedPatternDrawCallback;

to ignore [mWindow drawsContentsIntoWindowFrame] and use RepeatedPatternDrawCallback always. RepeatedPatternDrawCallback should already do the right thing.

But couldn't we just do the accent color fallback only for the OpenGL case? You could add a isUsingOpenGL method to the ChildView class and query that from setFill.

Comment 3

[Joe Drew (not getting mail)]

Attachment: address comments

Hope you don't mind - I just subsumed your patch in the other bug, since it's needed for this one.

Comment 4

[Joe Drew (not getting mail)]

Attachment: address comments v2

this time with more qrefresh

Comment 5

[Joe Drew (not getting mail)]

http://hg.mozilla.org/mozilla-central/rev/a976293325c6