Closed Bug 599258 Opened 9 years ago Closed 9 years ago

ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_bug561636.html

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b7

People

(Reporter: dougt, Assigned: mounir)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

Assignee: nobody → mounir.lamouri
00:01 < volkmar> it looks like the last form is never used
00:02 < volkmar> so the same form is used twice which may provec double form submissions some times breaking note think preventing one event preventing the 
                 finish() call
Status: NEW → ASSIGNED
Component: IPC → DOM: Core & HTML
OS: Windows XP → All
QA Contact: ipc → general
Version: unspecified → Trunk
Blocks: 438871
Attached patch Patch v1 (obsolete) — Splinter Review
This test was a mess!
I forgot to call the test at onload which make the onload event for the second iframe showing up mostly all the time _after_ the addEventListener and making the test finishing green.
But, if the load event was fired before the addEventListener, there were no way to have the test finishing.

In addition, the last .submit() was not done on the correct form.

Damn, I'm not proud of that :(
Attachment #478200 - Flags: review?(doug.turner)
Attached patch Patch v1Splinter Review
Better with the correct patch....
Attachment #478202 - Flags: review?(doug.turner)
Attachment #478200 - Attachment is obsolete: true
Attachment #478200 - Flags: review?(doug.turner)
Attachment #478202 - Flags: review?(doug.turner) → review+
mounir, thanks for the fast turn around!
http://hg.mozilla.org/mozilla-central/rev/842d82ff333c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b7
Flags: in-testsuite+
Depends on: 599628
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.