[BLOCKED] ender-nsHTMLInputElement has a pointer to nsIWidget

VERIFIED FIXED in M6

Status

()

Core
Layout
P1
blocker
VERIFIED FIXED
19 years ago
11 years ago

People

(Reporter: buster, Assigned: Kevin McCluskey (gone))

Tracking

Trunk
All
Windows NT
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

19 years ago
nsHTMLInputElement is a content class for text fields.  It has a reference to
nsIWidget, assuming that text fields are implemented using native widgets.  This
is wrong.  When frame-level interaction is required, nsHTMLInputElement should
go through the frame that is mapping the content, not directly to the widget.

Fixing this will enable us to replace native text widgets with Ender for text
input fields.  Kevin estimates the time to fix as approximately 2 days.  He has
done similar work for other content objects.
(Reporter)

Updated

19 years ago
Priority: P3 → P1
Target Milestone: M6
(Reporter)

Comment 1

19 years ago
optimistically setting milestone to M6.  I plan on starting implementation of
Ender text fields on 5/19 for inclusion in M7.
(Reporter)

Comment 2

19 years ago
There is a second place where a widget is unfairly assumed.  nsFileControlFrame
holds onto a nsTextControlFrame* mTextFrame.  This is fine, except it calls
mTextFrame->GetWidget(&widget);, then does a QI to an nsITextWidget and makes
calls on that text widget.  It should just make calls on the text frame itself,
and let the frame decide how to deal with the underlying implementation.
(Assignee)

Updated

19 years ago
Status: NEW → ASSIGNED

Comment 3

19 years ago
who is blocked on this, and why?

Updated

19 years ago
Summary: [BLOCKED] nsHTMLInputElement has a pointer to nsIWidget → [BLOCKED] ender-nsHTMLInputElement has a pointer to nsIWidget
(Assignee)

Updated

19 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

19 years ago
Fixed in 5-13-99 5:03PM build. I removed all remaining references to nsIWidget
in the HTML form element content objects. I also removed the reference to
nsITextWidget in the file control.

Updated

19 years ago
Status: RESOLVED → VERIFIED

Comment 5

19 years ago
Fixed in 5/17 Build

Updated

11 years ago
URL: none
You need to log in before you can comment on or make changes to this bug.