59933 - Mozilla font size prefs shouldn't affect chrome fonts

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Adrian Havill]

Under some Japanese systems (like Red Hat Linux 7J), the text in the mailnews
interface such as "Get Mail" and "Send Mail" is larger than normal because of
the default font used on Japanese systems.

This increases the amount of vertical space that the toolbar takes up, and
produces an unsightly white "blank" area at the bottom of the toolbar because
the theme/skin only fills up a set amount of space based on a Latin-1 font.

Comment 1

[Adrian Havill]

Attachment: screenshot showing oversized text

Comment 2

[Matthew T (active 1999-2002)]

Confirming based on screenshot, but this isn't a UI design issue, it's an 
implementation issue. Over to Themes.

Does this also happen with the Classic theme?

Comment 3

[Adrian Havill]

The font is still large like Modern, but Classic looks ok. (IOW, no "white clip"
with the font decenders for "g" spilling past the skin.

Blue also looks fine.

Comment 4

[Koike Kazuhiko]

I also see this. The text size of navigation toolbar seems to obey to
Japanese's variable-width font settings.

My build is 2000112204-Mtrunk on Win98J.

Comment 5

[Adrian Havill]

I also see alignment problems with the larger fonts with mailnews and the "Blue"
theme (look at the drop-down "triangle" under the print button icon... with the
larger text, the triangle is lost in the middle of the "Print" text and looks
like a graphics glitch)

Comment 6

[Adrian Havill]

Attachment: shows lost drop-down triangle in middle of ja font "Print" button text

Comment 7

[Christopher Blizzard (:blizzard)]

Adding ben + erik so they can ( hopefully ) comment.

Comment 8

[Erik van der Poel]

Yes, I have heard of many problems with the Modern theme. It hard-codes fonts
(instead of using CSS system fonts), and it hard-codes various UI element sizes
(bad bad).

Comment 9

[hangas]

System font coming soon to Modern.  Sending to Joe to close this bug when system 
fonts supported in Modern.

Comment 10

[Joe Hewitt (gone)]

Fixed - see fix for 16729.

Comment 11

[Koike Kazuhiko]

2000122105 on Win98J still has this problem.

Comment 12

[Joe Hewitt (gone)]

Koike, I've tested this with very large fonts on windows and don't see the
problem with the extra white space that you describe.  Can you please explain
what you are seeing that looks wrong, and perhaps include a screen shot?

Comment 13

[Koike Kazuhiko]

I didn't refer to the white space. The problem I still see is the text size
of navigation toolbar changes according to the Japanese's variable-width
font setting. Modern and Blue theme have this problem. Classic theme works
fine. I'll attach the screenshot.

Comment 14

[Koike Kazuhiko]

Attachment: Screenshot

Comment 15

[Joe Hewitt (gone)]

Koike, perhaps I'm not clear on the way font settings are working on your
system.  In your screen shot it appears one of your system font settings, the
one that corresponds to the CSS2 system font "message-box", is set to a very
large size. Is this because when you read Japanese text you prefer that size,
but in the case of reading English you don't want to adopt that size?

Comment 16

[Koike Kazuhiko]

I haven't changed "message-box" settings. The problem is that
the text size of navigation toolbar shoudn't be changed when
the font size is changed with preferences dialog.

Comment 17

[Joe Hewitt (gone)]

Ok, I see the problem now.  Changing summary...

Comment 18

[Joe Hewitt (gone)]

*** Bug 64824 has been marked as a duplicate of this bug. ***

Comment 19

[hangas]

Themes Triage Team nsbeta1+

Comment 20

[Joe Hewitt (gone)]

I've determined the problem here, and it goes beyond themes.  Whenever the
font-size css property is set to a relative value, like "smaller", the font is
rendered in a value that is relative to the user's font settings.  This is
incorrect, as the value should be relative to the inherited font-size.

Moving this bug over to Style System.

Comment 21

[Hixie (not reading bugmail)]

hewitt: that does not appear to be true, per this test case:
   http://www.hixie.ch/tests/adhoc/css/fonts/size/001.xml

Reassigning back to Themes. If you still think it is a style system bug, please
attach a test case that shows the problem. Thanks...

Comment 22

[Hixie (not reading bugmail)]

(Broke bug 72164 out of this bug.)

Comment 23

[hangas]

Themes Triage Team Marking nsbeta1+

Comment 24

[Joe Hewitt (gone)]

I do still think this is a style system problem.  The test case I'm about to
attach clearly demonstrates the problem.

Comment 25

[Joe Hewitt (gone)]

Attachment: test case showing bad font-size: smaller interpretation

Comment 26

[Pierre Saslawsky]

I think the bug happens when |smaller| results in a font size that is smaller 
than the |xx-small| of the font size selected in the prefs.

Comment 27

[Pierre Saslawsky]

I'm going to attach diffs.  When a |smaller| font size results in something 
smaller than the |xx-small| of the base font, we use the parent's font size. Same 
thing for |larger| and |xx-large|.

Marc, could you review?

Comment 28

[Pierre Saslawsky]

Attachment: diffs

Comment 29

[Marc Attinasi]

The diffs look fine - [s]r=attinasi

Pierre, how did you test this? Did Hewitt's testcase demonstrate the problem and
solution?

Comment 30

[Pierre Saslawsky]

Joe's excellent testcase did show the problem before and not after.  I also 
checked with http://www.w3.org/Style/CSS/Test/current/sec526.htm

Thanks for the review.

Comment 31

[Pierre Saslawsky]

fix checked in nsCSSStyleRule.cpp

Comment 32

[Madhur Bhatia]

verifying based on commetns