599382 - [TEST] Add some browser-chrome test for tapping

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch adds some basic tests for checking our tapping behavior for"
* TapSingle
* TapDouble
* TabLong

I want to add some context menu checking either in this test file or a new ne at some point soon too.

For some reason I can't get "TapSingle" to work? More eyes might help. I have it "todo" for now.

Another interesting item I found testing this patch. If I log the dumpEvents function I see two "TapSingle" events happening when no events are expected. Might be a latent bug. Only happens for the "two single taps in different locations" case:

TEST-INFO | chrome://mochikit/content/browser/mobile/chrome/browser_tapping.js | Test two single taps in different locations
---- event: TapSingle (this is expected)
---- event: TapSingle (this is expected)
TEST-PASS | chrome://mochikit/content/browser/mobile/chrome/browser_tapping.js | Fired two single taps in different places, not a double tap
---- event: TapSingle (what is this?!)
---- event: TapSingle (what is this?!)
TEST-INFO | chrome://mochikit/content/browser/mobile/chrome/browser_tapping.js | Test a pan - non-tap event

Comment 1

[Matt Brubeck (:mbrubeck)]

The patch is missing the new file?

(In reply to comment #0)
> Another interesting item I found testing this patch. If I log the dumpEvents
> function I see two "TapSingle" events happening when no events are expected.
> Might be a latent bug. Only happens for the "two single taps in different
> locations" case:

This was an intentional change in bug 599145.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2 (with the files)

Oops - here are the new files.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 3

This adds some tests for context menu types too. We now test for context menu types on links, images and images nested in links.

All tests, except the "TapSingle" test (as noted above) are passing.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/cb42087d4ec4