599466 - OpenGL function glGetError called on wrong GL context from GLDebugPrintError from ThebesLayerOGL::Destroy

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

All is in the title.

Found using the GL debug mode (MOZ_GL_DEBUG=1 environment variable, on a debug build, with the patch from bug 597881 applied).

Fatal: GLenum mozilla::gl::GLContext::fGetError() called on non-current context 0x3efc530. The current context for this thread is 0xaad9660.

Backtrace:

#0  0x000000385bea6a6d in nanosleep () from /lib64/libc.so.6
#1  0x000000385bea68e0 in sleep () from /lib64/libc.so.6
#2  0x00007fab5dcec868 in ah_crap_handler (signum=6)
    at /home/bjacob/mozilla-central/toolkit/xre/nsSigHandlers.cpp:132
#3  0x00007fab5dcf109a in nsProfileLock::FatalSignalHandler (signo=6, info=0x7fff0cccd3b0, 
    context=0x7fff0cccd280) at nsProfileLock.cpp:221
#4  <signal handler called>
#5  0x000000385be329a5 in raise () from /lib64/libc.so.6
#6  0x000000385be34185 in abort () from /lib64/libc.so.6
#7  0x00007fab5d1fc321 in mozalloc_abort (msg=
    0x7fff0cccd870 "###!!! ABORT: file ../../../dist/include/GLContext.h, line 1139")
    at /home/bjacob/mozilla-central/memory/mozalloc/mozalloc_abort.cpp:75
#8  0x00007fab5f362fd7 in Abort (aMsg=
    0x7fff0cccd870 "###!!! ABORT: file ../../../dist/include/GLContext.h, line 1139")
    at /home/bjacob/mozilla-central/xpcom/base/nsDebugImpl.cpp:379
#9  0x00007fab5f362ef9 in NS_DebugBreak_P (aSeverity=3, aStr=0x0, aExpr=0x0, aFile=
    0x7fab5fb2fa68 "../../../dist/include/GLContext.h", aLine=1139)
    at /home/bjacob/mozilla-central/xpcom/base/nsDebugImpl.cpp:337
#10 0x00007fab5e3bc7ef in mozilla::gl::GLContext::BeforeGLCall (this=0x3efc530, glFunction=
    0x7fab5fb35620 "GLenum mozilla::gl::GLContext::fGetError()")
    at ../../../dist/include/GLContext.h:1139
#11 0x00007fab5e3cd6a3 in mozilla::gl::GLContext::fGetError (this=0x3efc530)
    at ../../../dist/include/GLContext.h:1172
#12 0x00007fab5f474792 in mozilla::gl::GLDebugPrintError (aCx=0x3efc530, aFile=
    0x7fab5fe0a898 "/home/bjacob/mozilla-central/gfx/layers/opengl/ThebesLayerOGL.cpp", aLine=
    444) at /home/bjacob/mozilla-central/gfx/thebes/GLContext.h:2218
#13 0x00007fab5f4a9ce8 in mozilla::layers::ThebesLayerOGL::Destroy (this=0xad7fe70)
    at /home/bjacob/mozilla-central/gfx/layers/opengl/ThebesLayerOGL.cpp:444
#14 0x00007fab5f49e3af in mozilla::layers::ContainerLayerOGL::Destroy (this=0xa065350)
    at /home/bjacob/mozilla-central/gfx/layers/opengl/ContainerLayerOGL.cpp:60
#15 0x00007fab5f49e2e4 in mozilla::layers::ContainerLayerOGL::~ContainerLayerOGL (this=
    0xa065350, __in_chrg=<value optimized out>)
    at /home/bjacob/mozilla-central/gfx/layers/opengl/ContainerLayerOGL.cpp:52
#16 0x00007fab5f49e34c in mozilla::layers::ContainerLayerOGL::~ContainerLayerOGL (this=
    0xa065350, __in_chrg=<value optimized out>)
    at /home/bjacob/mozilla-central/gfx/layers/opengl/ContainerLayerOGL.cpp:53
#17 0x00007fab5df612c5 in mozilla::layers::Layer::Release (this=0xa065350)
    at ../../dist/include/Layers.h:442
#18 0x00007fab5f49e716 in mozilla::layers::ContainerLayerOGL::RemoveChild (this=0x3bd79d0, 
    aChild=0xa065350)
    at /home/bjacob/mozilla-central/gfx/layers/opengl/ContainerLayerOGL.cpp:125
#19 0x00007fab5df5da1f in mozilla::(anonymous namespace)::ContainerState::Finish (this=
    0x7fff0cccdea0) at /home/bjacob/mozilla-central/layout/base/FrameLayerBuilder.cpp:1318
#20 0x00007fab5df5e05c in mozilla::FrameLayerBuilder::BuildContainerLayerFor (this=
    0x7fff0ccce280, aBuilder=0x7fff0ccce280, aManager=0x3c0e450, aContainerFrame=0x27a21c8, 
    aContainerItem=0x0, aChildren=...)
    at /home/bjacob/mozilla-central/layout/base/FrameLayerBuilder.cpp:1411
#21 0x00007fab5dfa970a in nsDisplayList::PaintForFrame (this=0x7fff0ccce820, aBuilder=
    0x7fff0ccce280, aCtx=0x0, aForFrame=0x27a21c8, aFlags=1)
    at /home/bjacob/mozilla-central/layout/base/nsDisplayList.cpp:409
---Type <return> to continue, or q <return> to quit---
#22 0x00007fab5dfa9402 in nsDisplayList::PaintRoot (this=0x7fff0ccce820, aBuilder=
    0x7fff0ccce280, aCtx=0x0, aFlags=1)
    at /home/bjacob/mozilla-central/layout/base/nsDisplayList.cpp:360
#23 0x00007fab5dfd6b54 in nsLayoutUtils::PaintFrame (aRenderingContext=0x0, aFrame=0x27a21c8, 
    aDirtyRegion=..., aBackstop=4294967295, aFlags=4)
    at /home/bjacob/mozilla-central/layout/base/nsLayoutUtils.cpp:1429
#24 0x00007fab5dffe395 in PresShell::Paint (this=0x2798090, aDisplayRoot=0x2796ac0, 
    aViewToPaint=0x2796ac0, aWidgetToPaint=0x2796b50, aDirtyRegion=..., aIntDirtyRegion=..., 
    aPaintDefaultBackground=0, aWillSendDidPaint=0)
    at /home/bjacob/mozilla-central/layout/base/nsPresShell.cpp:6089
#25 0x00007fab5e5ddc2b in nsViewManager::RenderViews (this=0x278a4b0, aView=0x2796ac0, aWidget=
    0x2796b50, aRegion=..., aIntRegion=..., aPaintDefaultBackground=0, aWillSendDidPaint=0)
    at /home/bjacob/mozilla-central/view/src/nsViewManager.cpp:447
#26 0x00007fab5e5dda8e in nsViewManager::Refresh (this=0x278a4b0, aView=0x2796ac0, aWidget=
    0x2796b50, aRegion=..., aUpdateFlags=1)
    at /home/bjacob/mozilla-central/view/src/nsViewManager.cpp:413
#27 0x00007fab5e5df16a in nsViewManager::DispatchEvent (this=0x278a4b0, aEvent=0x7fff0cccf050, 
    aView=0x2796ac0, aStatus=0x7fff0ccceec4)
    at /home/bjacob/mozilla-central/view/src/nsViewManager.cpp:913
#28 0x00007fab5e5d91a6 in HandleEvent (aEvent=0x7fff0cccf050)
    at /home/bjacob/mozilla-central/view/src/nsView.cpp:161
#29 0x00007fab5efc514c in nsWindow::DispatchEvent (this=0x2796b50, aEvent=0x7fff0cccf050, 
    aStatus=@0x7fff0cccf14c) at /home/bjacob/mozilla-central/widget/src/gtk2/nsWindow.cpp:733
#30 0x00007fab5efc8f12 in nsWindow::OnExposeEvent (this=0x2796b50, aWidget=
    0x17d56a0 [MozContainer], aEvent=0x7fff0cccf820)
    at /home/bjacob/mozilla-central/widget/src/gtk2/nsWindow.cpp:2300
#31 0x00007fab5efd2248 in expose_event_cb (widget=0x17d56a0 [MozContainer], event=
    0x7fff0cccf820) at /home/bjacob/mozilla-central/widget/src/gtk2/nsWindow.cpp:5658
#32 0x000000312f551003 in _gtk_marshal_BOOLEAN__BOXED (closure=0x21013d0, return_value=
    0x7fff0cccf4e0, n_param_values=<value optimized out>, param_values=0xb0a16d0, 
    invocation_hint=<value optimized out>, marshal_data=<value optimized out>)
    at gtkmarshalers.c:84
#33 0x0000003860e0b98e in IA__g_closure_invoke (closure=0x21013d0, return_value=0x7fff0cccf4e0, 
    n_param_values=2, param_values=0xb0a16d0, invocation_hint=0x7fff0cccf4a0) at gclosure.c:767
#34 0x0000003860e1f947 in signal_emit_unlocked_R (node=<value optimized out>, detail=0, 
    instance=0x17d56a0, emission_return=0x7fff0cccf630, instance_and_params=0xb0a16d0)
    at gsignal.c:3248
#35 0x0000003860e20c29 in IA__g_signal_emit_valist (instance=<value optimized out>, 
    signal_id=<value optimized out>, detail=<value optimized out>, var_args=0x7fff0cccf690)
    at gsignal.c:2991
#36 0x0000003860e213a3 in IA__g_signal_emit (instance=<value optimized out>, 
    signal_id=<value optimized out>, detail=<value optimized out>) at gsignal.c:3038
#37 0x000000312f68190f in gtk_widget_event_internal (widget=0x17d56a0 [MozContainer], event=
    0x7fff0cccf820) at gtkwidget.c:4958
#38 0x000000312f54909e in IA__gtk_main_do_event (event=0x7fff0cccf820) at gtkmain.c:1583
#39 0x000000312fc4340a in _gdk_window_process_updates_recurse (window=0x1bdf340 [GdkWindow], 
    expose_region=0x8566cd0) at gdkwindow.c:5181
#40 0x000000312fc3fecb in gdk_window_process_updates_internal (window=0x1bdf340 [GdkWindow])
    at gdkwindow.c:5340
#41 0x000000312fc44a41 in IA__gdk_window_process_all_updates () at gdkwindow.c:5448

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: missing makecurrent call

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 478374 [details] [diff] [review]
missing makecurrent call

Huh, I was going to ask when this was being hit, but I can imagine when!

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/mozilla-central/rev/d7681817cf06