599472 - Vector.<Number> valueToAtom uses non SSE doubleToAtom

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Werner Sharp]

Atom valueToAtom(double value) const
        {
            return core()->doubleToAtom(value);
        }

Investigate whether a runtime sse2 check here and calling doubleToAtom_sse2 helps performance.

Therre are a few other hardcoded integer_d and/or doubleToAtom calls in the code such as AvmCore::integer, etc.  I've seen the Vector.<Number> one high on a VTUNE profile but not the others.

Comment 1

[Edwin Smith]

Arguably, the JIT should not use the non-native get or helpers that call valueToAtom or atomToValue(), but instead inline the value coersion or boxing code.  In either case, the existing JIT code will use the faster doubleToAtom_sse2, or coerce logic.

If this is pursued, its important not to change the order of side effects. See bug 687338.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Tamarin isn't maintained anymore. WONTFIX remaining bugs.