599483 - Generating a new custom sync key doesn't have notification message

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Tony Chung [:tchung]]

When creating a customized sync key, the UI is missing the throbber and notification status message.   However, generating with the auto-generated will show the message

Philip thinks its a regression from bug 592465.

Repro:
1) install Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b7pre) Gecko/20100924 Firefox/4.0b7pre
2) log into a valid sync accont
3) open prefs > My Sync Key
4) Delete existing key, and create your own (eg. "thisismynewsynckey")
5) Click "Change Sync Key"
6) verify there is no notification message and throbber that the work is in progress.  However, do step 4 with a generated sync key, and you'll see the message

Expected:
- Notification message that custom key is being generated

Actual:
- missing

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Ensure that the status text row is always shown and the passphrase meter is always hidden when we're showing status messages likes "updating".

Also disable Print + Save buttons when changing the sync key, akin to disabling the other dialog buttons.

Comment 2

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/services/fx-sync/rev/93ad6f3ba451

Comment 3

[Tracy Walker [:tracy]]

verified with recent nightly builds of minefield

Comment 4

[Philipp von Weitershausen [:philikon]]

(In reply to comment #3)
> verified with recent nightly builds of minefield

Note that this bug is about the add-on UI (you can tell by the fact that this landed in the fx-sync repo)