599490 - "cfx test -F private\|selection" in jetpack-core causes errors

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Atul Varma [:atul]]

Here's where it dies:

  info: executing 'test-private-browsing.testCallbackThisStop'
  info: pass: |this| == pb in onAfterStart
  info: pass: |this| == pb in onBeforeStop
  info: pass: |this| == pb in onStop
  info: pass: |this| == pb in onAfterStop
  info: executing 'test-selection.testContiguousMultiple'
  error: TEST FAILED: test-selection.testContiguousMultiple (failure)
  error: fail: selection.contiguous multiple works. (null != false)

This results in a bunch of errors in test-selection, not sure if it's a chain reaction or not, but clearly private browsing is finishing with the browser in a state that test-selection does not expect.

Comment 1

[Atul Varma [:atul]]

Note that this bug is coming from a tree where "cfx test" in jetpack-core works just fine, as does "cfx testall", and individually testing the private-browsing and selection modules separately also works.

Comment 2

[Atul Varma [:atul]]

Attachment: patch

Comment 3

[Atul Varma [:atul]]

The problem occurring, I think, is that if the adding of a tab used by the selection tests resulted in the creation of a new browser window, an "about:blank" tab would be opened along with the tab that was just opened--perhaps this is related to coming out of private browsing mode, since about:blank is the user's homepage in the testing profile--and the testing function would be called *twice*, once for about:blank and once for the real data URL tab.

Kind of weird, but I just added a check that makes sure the document that triggered the whenContentLoaded() callback was the document we expect it to be--and if it's not, we don't do anything.

Comment 4

[Atul Varma [:atul]]

Pushed:

Bug 599490 - "cfx test -F private\|selection" in jetpack-core causes errors
Atul Varma [:atul]
http://hg.mozilla.org/labs/jetpack-sdk/rev/a225ce1b7d27

Comment 5

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".