Closed
Bug 599558
Opened 14 years ago
Closed 14 years ago
Button elements should not have :optional applying to them
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
People
(Reporter: mounir, Assigned: Ms2ger)
References
()
Details
(Whiteboard: [good first bug])
Attachments
(1 file, 1 obsolete file)
1.98 KB,
patch
|
sicking
:
approval2.0+
|
Details | Diff | Splinter Review |
I was going to open this bug anyway but the specifications have just changed :)
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → Ms2ger
Reporter | ||
Comment 1•14 years ago
|
||
I want to have that fixed for beta8 so let me know if you think you can't have it fixed for beta8, I will take the bug.
Assignee | ||
Comment 2•14 years ago
|
||
Assignee | ||
Updated•14 years ago
|
Attachment #481557 -
Flags: review?(jonas)
Reporter | ||
Comment 3•14 years ago
|
||
Comment on attachment 481557 [details] [diff] [review] Remove support for the :optional pseudo-class on button. >diff --git a/layout/reftests/css-optional/css-optional-button.html b/layout/reftests/css-optional/css-optional-button.html >--- a/layout/reftests/css-optional/css-optional-button.html >+++ b/layout/reftests/css-optional/css-optional-button.html >@@ -1,7 +1,11 @@ > <!DOCTYPE html> > <html> >- <link rel='stylesheet' type='text/css' href='css-optional-style.css'> >+ <style> >+ :optional { >+ visibility: hidden; >+ } >+ </style> > <body> > <button></button> > </body> > </html> >diff --git a/layout/reftests/css-optional/css-optional-style.css b/layout/reftests/css-optional/css-optional-style.css >--- a/layout/reftests/css-optional/css-optional-style.css >+++ b/layout/reftests/css-optional/css-optional-style.css >@@ -1,8 +1,8 @@ >-input, textarea, select, button, >+input, textarea, select, > *:required { > visibility: hidden; > } > > *:optional { > visibility: visible; > } I would have changed the stylesheet to have button always hidden and make them visible if optional so reftest.list can compare the button file with about:blank (we save some bits). As is, the patch would be fine if, at least, you move the CSS rule from the html file to the CSS one.
Attachment #481557 -
Flags: feedback+
Comment on attachment 481557 [details] [diff] [review] Remove support for the :optional pseudo-class on button. r=me with Mounir's requested changes.
Attachment #481557 -
Flags: review?(jonas) → review+
Assignee | ||
Updated•14 years ago
|
Attachment #481557 -
Attachment is obsolete: true
Assignee | ||
Comment 5•14 years ago
|
||
Assignee | ||
Comment 6•14 years ago
|
||
Comment on attachment 481638 [details] [diff] [review] Remove support for the :optional pseudo-class on button (for checkin) Jonas, I claimed a=you. Could you confirm?
Attachment #481638 -
Attachment description: Remove support for the :optional pseudo-class on button; f=volkmar r+ → Remove support for the :optional pseudo-class on button (for checkin)
Attachment #481638 -
Flags: approval2.0?
Attachment #481638 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Updated•14 years ago
|
Whiteboard: [good first bug] → [good first bug][can land]
Reporter | ||
Comment 7•14 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/5ad6ebfbed1b
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [good first bug][can land] → [good first bug]
Target Milestone: --- → mozilla2.0b8
Updated•14 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•