599576 - Talos Regression :( Ts increase 22.1% on Nokia n900 mobile

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Previous: avg 7752.540 stddev 74.267 of 30 runs up to revision 54af7f2df238
New     : avg 9468.978 stddev 14.813 of 5 runs since revision 6ce6d5e09a55
Change  : +1716.438 (22.1% / z=23.112)
Graph   : http://mzl.la/9MspZZ

Changeset range: http://hg.mozilla.org/mobile-browser/pushloghtml?fromchange=54af7f2df238&tochange=6ce6d5e09a55

Bugs:
  * bug 599512 - Partial black thumbnails on viewports with width != 800
  * bug 599053 - text typed in awesome bar shows up on previously focused form field
  * bug 599501 - Browser fights me when I try to zoom

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch seems to recover much of the lost Ts and still seems to not regress bug 599512. I could only try this locally on my N900. We'll need to push it to see if tinderbox likes it as much as my N900 did.

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 478502 [details] [diff] [review]
patch

This looks good, and does not regress the black thumbnails.

I'd also be curious whether thumbnailing a smaller area is faster.  For example, we could set "width = Math.max(800, width)" in documenttab.updateThumbnail.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

This patch was not enough to fix the Ts regression. I backed out all suspected patches (see comment 0). I'll land them one at a time to see which one caused the regression.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Ts regression is gone and we plan on fixing bug 599053 using a different strategy. Closing this bug as fixed by the backout.