Closed Bug 599608 Opened 14 years ago Closed 14 years ago

Context menu selections are not functional in the Compose Window

Categories

(Thunderbird :: Message Compose Window, defect)

x86
Windows XP
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.3a1

People

(Reporter: u382332, Assigned: standard8)

Details

(Keywords: regression)

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.10) Gecko/20100914 Firefox/3.6.10
Build Identifier: 

Mozilla/5.0 (Windows NT 5.1; rv:2.0b7pre) Gecko/20100924 Thunderbird/3.3a1pre

Undo, Cut, Copy, Paste and Select All are not functional in the Compose window.

Paste Without Formatting and Paste As Quotation are functional.

Reproducible: Always
Version: unspecified → Trunk
Confirmed..
Keyboard shortcuts (ctrl+a) etc, seem to work fine.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Anybody willing to go on a regression hunt ?
This as close as I can get you.

Works:
Mozilla/5.0 (Windows NT 5.1; rv:2.0b7pre) Gecko/20100915 Thunderbird/3.3a1pre

Does not work:
Mozilla/5.0 (Windows NT 5.1; rv:2.0b7pre) Gecko/20100922 Thunderbird/3.3a1pre

There were no win32 builds between those dates.
blocking-thunderbird3.2: --- → ?
blocking-thunderbird3.2: ? → ---
Flags: blocking-thunderbird-next+
Attached patch The fixSplinter Review
The issue here is that the revised method of building means that we're building mail/components/compose before editor/ui and this is causing a file to be overridden with an SM version.

There's two things wrong here, one is that we've got different versions of the same file and Thunderbird is overriding one, the second is that the order is unexpected.

This patch "fixes" the second by re-running it after editor/ui has run. Really we need static libxul here.

Wrt the first option, I've not worked out yet what would be needed to get rid of the overriding case or if they could be combined. It'll be worth raising a second bug on it though.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #480058 - Flags: review?(bugspam.Callek)
Comment on attachment 480058 [details] [diff] [review]
The fix

not fond of this, but if it gets TB working again, go ahead.
Attachment #480058 - Flags: review?(bugspam.Callek) → review+
(In reply to comment #4)
> Created attachment 480058 [details] [diff] [review]
> The fix
> 
> The issue here is that the revised method of building means that we're building
> mail/components/compose before editor/ui and this is causing a file to be
> overridden with an SM version.

If the file in editor/ui is SeaMonkey-only I think its worth pulling into suite/* and out of mozilla-central at the least, and merge or not can be *yet* another bug.

And pulling it out of editor/ui will actually negate the need for this hack, aiui.
Hmm. How about putting an override line in the thunderbird *.manifesst file. We do this in suite when we need to override a toolkit file. This way you don't need any hacks to build config since the override happens at runtime.
(In reply to comment #7)
> Hmm. How about putting an override line in the thunderbird *.manifesst file. We
> do this in suite when we need to override a toolkit file. This way you don't
> need any hacks to build config since the override happens at runtime.
Did you not read comment #4?
Bah, I realised what you were really on about just after clicking submit. Sorry.
Attached patch Alternate fixSplinter Review
Alternative fix - make editorOverlay.xul suite specific.

I took a more detailed look at the diffs. Once you get beyond the fact that the current editor/ui version includes SM specific file platformCommunicatorOverlay.dtd, but doesn't really need to, you then start digging down into the menus defined in the file. The menus are clearly specific to having composer functionality.

I think this then comes down to a discussion about what exactly is editor, what should it contain and how should it function in being included in apps. I don't think that discussion needs to be had now.

Therefore I'm proposing that we make editorOverlay.xul suite-specific by moving it to within the ifdef in the jar.mn as this matches what we've done with the other files.
Attachment #481008 - Flags: review?(neil)
Comment on attachment 481008 [details] [diff] [review]
Alternate fix

For what its worth, I like this better than the other fix. And it looks good to me, so imho it just needs neil's stamp.
Attachment #481008 - Flags: review+
Comment on attachment 481008 [details] [diff] [review]
Alternate fix

Nit: in the original CVS version of jar.mn, editorOverlay.xul (and editorOverlay.js, but that's not forked) lived between EditorParagraphMarks.css and composerOverlay.xul, so that's where it should go in the MOZ_SUITE block.
Attachment #481008 - Flags: review?(neil) → review+
Checked in with nit addressed: http://hg.mozilla.org/comm-central/rev/d0ee84d37ec8
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a1
Confirmed fixed. Thanks Mark.

Mozilla/5.0 (Windows NT 5.1; rv:2.0b7pre) Gecko/20101006 Thunderbird/3.3a1pre
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: