599614 - Fix 'defined' and 'echo' syntax in .bat files

Status: RESOLVED WONTFIX

(Firefox Build System :: MozillaBuild, task)

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) 'defined' needs no '%', 'echo' needs no '"'

Comment 2

[(not currently active) Ted Mielczarek]

This is silly make-work. It may not be necessary, but it's not causing any problems, so why bother? You'll just obscure blame.

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 478531 [details] [diff] [review]
(Av1) 'defined' needs no '%', 'echo' needs no '"'

(In reply to comment #2)
> it's not causing any problems

Is it not?
On my Win2K,
*'"' are displayed, which is unexpected. (see other 'echo')
*'defined' tests fail, because the syntax is wrong. (see other 'defined')

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) 'defined' needs no '%', 'echo' needs no '"', Add missing years

Av1, fixed, plus some more consistency.

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) 'set' needs no '"', Resync' and clean start-msvc6.bat and start-msvc71.bat up

These do not break anything, but are uselessly more complicated than needed.

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 478960 [details] [diff] [review]
(Av2) 'defined' needs no '%', 'echo' needs no '"', Add missing years

No, I really don't care. This works fine on my Windows 7 system. If it's broken on Windows 2000, it doesn't matter. This is not critical functionality anyway.

Comment 7

[Serge Gautherie (:sgautherie)]

:-(

Comment 8

[Michael Kraft [:morac]]

I'll mention that the "defined" usage is wrong on Windows XP as well. 

It doesn't hurt anything, but the guess-msvc.bat won't list which version of VC++ if any is installed.