[SeaMonkey] mochitests-1/5: "TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_bug561636.html | Test timed out."

VERIFIED FIXED in mozilla2.0b7

Status

()

Core
DOM: Core & HTML
VERIFIED FIXED
8 years ago
6 years ago

People

(Reporter: Bruno 'Aqualon' Escherl, Assigned: mounir)

Tracking

(Blocks: 1 bug, {intermittent-failure})

Trunk
mozilla2.0b7
intermittent-failure
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Probably the result from bug 599258. We don't even get to the first check in that test, so the hang occurs somewhere else.
Does this fail locally, and if so can you check if there are any existing observers for invalidformsubmit registered. [I don't see how]

But this test shouldn't call |waitForExplicitFinish| if there are no observers and thus shouldn't time out.

Updated

8 years ago
Whiteboard: [orange]
(Assignee)

Comment 2

8 years ago
Created attachment 478592 [details] [diff] [review]
Patch v1
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #478592 - Flags: review?(bugspam.Callek)
(Assignee)

Comment 3

8 years ago
The test is run when onload is called. waitForExplicitFinish should have been called before. I don't see how that might break SeaMonkey but that was a mistake. So, now finish() is explicitly call if there is no observer.
Comment on attachment 478592 [details] [diff] [review]
Patch v1

Unable to test locally right now, so feedback+ If you want an official review before being willing to push this, re-request and I'll be sure to do just that [with local testing]. code-inspection-wise this looks good though.
Attachment #478592 - Flags: review?(bugspam.Callek) → feedback+
Interesting... I didn't fail this locally.... :/
(Reporter)

Comment 6

8 years ago
The test hang for me and passes with the patch. So looks good.
(Reporter)

Updated

8 years ago
Depends on: 599745
Component: Testing Infrastructure → DOM: Core & HTML
Product: SeaMonkey → Core
QA Contact: testing-infrastructure → general
Summary: TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_bug561636.html | Test timed out. → [SeaMonkey] mochitests-1/5: "TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_bug561636.html | Test timed out."
(Assignee)

Comment 7

8 years ago
Justin, according to comment 5, you were able to test this. May I have you r+? :)
(In reply to comment #7)
> Justin, according to comment 5, you were able to test this. May I have you r+?
> :)

c#5 was about with_out_ this patch, I didn't fail locally....  but r+ anyway based on Aqualon's c#6
(Assignee)

Comment 9

8 years ago
http://hg.mozilla.org/mozilla-central/rev/d0d3ac2ce08c
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite+
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b7
(In reply to comment #9)
> http://hg.mozilla.org/mozilla-central/rev/d0d3ac2ce08c

    1.32 +  if (!observers.hasMoreElements()) {

Nit: adding an explicit todo(false, ...) or ok(true, ...) would be perfect.

    1.33 +    SimpleTest.finish();
    1.34 +    return;
    1.35 +  }
(Assignee)

Comment 11

8 years ago
The current mochitest behavior is to add a todo if there is no test. Isn't that enough?
(In reply to comment #11)
> The current mochitest behavior is to add a todo if there is no test. Isn't that
> enough?

Yes it is. And I have not seen this on any runs of the test for SeaMonkey machines since this landed--> Verified
Status: RESOLVED → VERIFIED

Updated

6 years ago
Depends on: 779720

Updated

6 years ago
No longer depends on: 779720
Keywords: intermittent-failure
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.