599657 - "WARNING: Ignoring duplicate observer." due to duplicate metrics in nsXPLookAndFeel.cpp

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I decided to see what was causing the first warning printed to the console when starting Firefox.  It turns out to be that nsXPLookAndFeel.cpp has two different metrics that are the same thing:

one is an int:
  { "ui.listVerticalInsidePadding", eMetric_ListVerticalInsidePadding,
    PR_FALSE, nsLookAndFeelTypeInt, 0 },

and the other is a float:  { "ui.listVerticalInsidePadding",
    eMetricFloat_ListVerticalInsidePadding, PR_FALSE, nsLookAndFeelTypeFloat, 0 },
This seems like a mistake.


Furthermore, I think they're both unused.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: remove unused system metrics

A large number of system metrics are dead code.  We should remove them.  It saves code size and pref observers.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 478582 [details] [diff] [review]
remove unused system metrics

Low risk patch to remove unused code (which is in our startup path).

Comment 3

[Joe Drew (not getting mail)]

Comment on attachment 478582 [details] [diff] [review]
remove unused system metrics

post-b7

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/1aab37daf3bc