599708 - UpdateFolderWithListener should properly indicate when it's done

Status: NEW

(MailNews Core :: Filters, defect)

Description

[Bruno 'Aqualon' Escherl]

As Kent mentioned in bug 584327 comment #9 this could be a core bug. Perhaps this could be also related to the random oranges we get e.g. for test_imapUndo.js?

Comment 1

[Bruno 'Aqualon' Escherl]

This could be related to bug 580179.

Comment 2

[Kent James (:rkent)]

I spent quite a bit of time trying to get updateFolderWithListener working more reliably in tests, trying to get test_imapPlayback working with maildir in bug 1113275. The issues have to do with nsImapOfflineSync which returns early while urls are still running.

I ultimately decided that, for the purposes of bug 1113275, then changes needed were too extensive and unrelated to getting maildir working. I could get maildir working by not trying to restart the test like we do in other tests.

I'll post the patch I was working on, which does not work but a least shows some of the areas where the problems exist.

Comment 3

[Kent James (:rkent)]

Attachment: Not working, but shows some of the issues

Comment 4

[u695164]

For me it seems like the reasons to upgrade UpdateFolderWithListener was the test infrastructure.
This reason should be gone with the usage of PromiseTestUtils.

PromiseUrlListener

https://searchfox.org/comm-central/rev/9ebb9d17182a3fef3b11a30fcbec14db9a2949fe/mailnews/test/resources/PromiseTestUtils.jsm#25

Example Usage

https://searchfox.org/comm-central/rev/9ebb9d17182a3fef3b11a30fcbec14db9a2949fe/mailnews/base/test/unit/test_detachToFile.js#85

If you have another usage besides the test infrastructure we could consider adding this feature.