59975 - general.useragent.override ignored

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P3)

Description

[Terry Hayes]

The general.useragent.override preference value is supposed to be used in place
of the computed useragent value.  However this value is read once when the HTTP
service is created, which may be early in the application initialization,
before a user profile is selected.

In particular, the layout code sets specific attributes of the user agent string
(Necko version number) prior to the user selecting a profile.  I've attached a
stack trace showing this.  Since the http protocol service does not register
pref callbacks for values that may change when the user profile is read, the
override value has no effect.

Comment 1

[Terry Hayes]

Attachment: Stack trace of layout creating http service

Comment 2

[Gagan]

->neeti

Comment 3

[neeti]

Terry,

Where is the preference general.useragent.override defined? I can't seem to find 
it.

Thanks,
Neeti

Comment 4

[Terry Hayes]

I'm not sure it's *defined* anywhere.  The default value is the empty string, or
just "not defined".

It's used in the http protocol handler
/netwerk/protocol/http/src/nsHTTPHandler.cpp, line 625

Comment 5

[neeti]

Attachment: attaching fix for bug

Comment 6

[Darin Fisher]

r=darin on the patch.

Comment 7

[neeti]

Scott,

Can I get a super review for this patch.

Thanks,
Neeti

Comment 8

[Scott MacGregor]

you sure can, sr=mscott

Comment 9

[neeti]

Fix checked in