general.useragent.override ignored

RESOLVED FIXED

Status

()

P3
normal
RESOLVED FIXED
18 years ago
16 years ago

People

(Reporter: thayes0993, Assigned: neeti)

Tracking

Trunk
x86
Windows NT
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

18 years ago
The general.useragent.override preference value is supposed to be used in place
of the computed useragent value.  However this value is read once when the HTTP
service is created, which may be early in the application initialization,
before a user profile is selected.

In particular, the layout code sets specific attributes of the user agent string
(Necko version number) prior to the user selecting a profile.  I've attached a
stack trace showing this.  Since the http protocol service does not register
pref callbacks for values that may change when the user profile is read, the
override value has no effect.
(Reporter)

Comment 1

18 years ago
Created attachment 19165 [details]
Stack trace of layout creating http service

Comment 2

18 years ago
->neeti
Assignee: gagan → neeti
(Assignee)

Comment 3

18 years ago
Terry,

Where is the preference general.useragent.override defined? I can't seem to find 
it.

Thanks,
Neeti
Status: NEW → ASSIGNED
(Reporter)

Comment 4

18 years ago
I'm not sure it's *defined* anywhere.  The default value is the empty string, or
just "not defined".

It's used in the http protocol handler
/netwerk/protocol/http/src/nsHTTPHandler.cpp, line 625
(Assignee)

Comment 5

18 years ago
Created attachment 22263 [details] [diff] [review]
attaching fix for bug

Comment 6

18 years ago
r=darin on the patch.
(Assignee)

Comment 7

18 years ago
Scott,

Can I get a super review for this patch.

Thanks,
Neeti

Comment 8

18 years ago
you sure can, sr=mscott

(Assignee)

Comment 9

18 years ago
Fix checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Updated

16 years ago
QA Contact: tever → benc

Updated

16 years ago
Component: Networking → Networking: HTTP
QA Contact: benc → tever
You need to log in before you can comment on or make changes to this bug.