Closed
Bug 599751
Opened 14 years ago
Closed 14 years ago
Javascript strict warnings in nsSearchService.js
Categories
(Firefox :: Search, defect)
Firefox
Search
Tracking
()
RESOLVED
FIXED
Firefox 4.0b7
People
(Reporter: mnyromyr, Assigned: sgautherie)
References
()
Details
Attachments
(1 file)
|
5.28 KB,
patch
|
Gavin
:
review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
While reviewing the v2 patch for bug 410613, I started SeaMonkey trunk with a Sherlock search as default and sidebar search open, which showed these strict warnings in the toolkit core code: Warning: assignment to undeclared variable valueEnd Source File: file:///.../dist/bin/components/nsSearchService.js Line: 1822 Warning: assignment to undeclared variable lines Source File: file:///.../dist/bin/components/nsSearchService.js Line: 1834 (Due to preprocessing madness, the actual lines are currently 1870 and 1882.)
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → sgautherie.bz
Severity: normal → minor
Status: NEW → ASSIGNED
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
Version: unspecified → Trunk
|
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #478683 -
Flags: review?
|
|
Assignee | |
Updated•14 years ago
|
Attachment #478683 -
Flags: review? → review?(rflint)
|
||
Updated•14 years ago
|
Component: Find Toolbar → Search
Product: Toolkit → Firefox
QA Contact: fast.find → search
|
|
||
Comment 2•14 years ago
|
||
Comment on attachment 478683 [details] [diff] [review] (Av1) Add 2 missing 'let' [Checked in: See comment 3] r=me for just the "let" addition - don't make any of the whitespace changes.
Attachment #478683 -
Flags: review?(rflint)
Attachment #478683 -
Flags: review+
Attachment #478683 -
Flags: approval2.0+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Comment on attachment 478683 [details] [diff] [review] (Av1) Add 2 missing 'let' [Checked in: See comment 3] http://hg.mozilla.org/mozilla-central/rev/c00f150e33d8 (In reply to comment #2) > don't make any of the whitespace changes. Would you accept them in a separate patch or not at all?
Attachment #478683 -
Attachment description: (Av1) Add 2 missing 'let' → (Av1) Add 2 missing 'let'
[Checked in: See comment 3]
|
|
Assignee | |
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
|
|
||
Comment 4•14 years ago
|
||
I don't think they're worth making at all.
|
||
Updated•14 years ago
|
Target Milestone: Firefox 4.0b8 → Firefox 4.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•