599762 - TM: set right compartment in js::ctypes::CClosure::ClosureStub

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gregor Wagner [:gwagner]]

2  libmozjs.so!JS_CallFunctionValue [jsapi.cpp:ef1f16975962 : 4898 + 0x31]
    eip = 0x006acea4   esp = 0xa44ed310   ebp = 0xa44ed358   ebx = 0x00a1968c
    Found by: call frame info
 3  libmozjs.so!js::ctypes::CClosure::ClosureStub [CTypes.cpp:ef1f16975962 : 5373 + 0x52]
    eip = 0x0095b28a   esp = 0xa44ed360   ebp = 0xa44ed4f8   ebx = 0x00a1968c
    esi = 0xa44ed3b4   edi = 0x00000001
    Found by: call frame info
 4  libmozjs.so!ffi_closure_SYSV_inner [ffi.c:ef1f16975962 : 384 + 0x27]
    eip = 0x009706a6   esp = 0xa44ed500   ebp = 0xa44ed558   ebx = 0x00a1968c
    esi = 0x0095ae5d   edi = 0xa1883240
    Found by: call frame info
 5  libmozjs.so + 0x2ec89d
    eip = 0x0097089e   esp = 0xa44ed560   ebp = 0xa44ed588   ebx = 0x00a1968c
    esi = 0x00000001   edi = 0xa1883240
    Found by: call frame info
 6  libmozjs.so + 0x2ec7e1
    eip = 0x009707e2   esp = 0xa44ed590   ebp = 0xa44ed598   ebx = 0x00a1968c
    esi = 0x00000001   edi = 0xa1883240
    Found by: call frame info

http://tinderbox.mozilla.org/showlog.cgi?tree=MozillaTry&errorparser=unittest&logfile=1285526805.1285528507.21126.gz&buildtime=1285526805&buildname=Rev3%20Fedora%2012%20tryserver%20debug%20test%20mochitest-other&fulltext=1#err1

Comment 1

[Andreas Gal :gal]

Attachment: patch

Gregor, want to tryserver this?

Comment 2

[Andreas Gal :gal]

This is a callback stub and it has to enter the right compartment before calling back into JS.

Comment 3

[Gregor Wagner [:gwagner]]

I see this assertion now:
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1285574909.1285576615.23388.gz&fulltext=1#err0

Is this because of bug 599503?

Comment 4

[Andreas Gal :gal]

try jsfnObj instead of thisObj

Comment 5

[Gregor Wagner [:gwagner]]

Attachment: patch

changed thisObj.

Comment 6

[Gregor Wagner [:gwagner]]

Comment on attachment 479514 [details] [diff] [review]
patch

Argh wrong flag. Still Andreas patch.

Comment 7

[Johnny Stenback (:jst)]

This patch does fix the problem I ran into in the ctypes test in our chrome mochitests. This should be ready to land IMO, and I can do so unless someone tells me not to...

Comment 8

[Gregor Wagner [:gwagner]]

I am about to land this.

Comment 9

[Gregor Wagner [:gwagner]]

http://hg.mozilla.org/tracemonkey/rev/835980f51185

Comment 10

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/835980f51185