599775 - Controller needs to handle radio groups correctly

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Currently the controller only fires against a specific radio button. This should be changed so consumers only have to retrieve the radiogroup and not each of the button (which is sometimes even not possible due to the lack of unique identifiers). The API should look like the select function, and should allow you to specify the index, a value or the label.

This missing feature will block us by implementing some of the tests for the automatic/manual update checks of the new add-ons manager.

It would be awesome if we could fold this into the 1.5.1 release.

Comment 1

[cmtalbert]

Let's push this to 1.5.2 for now.  Rather do this one right than fast.

Comment 2

[cmtalbert]

This would be nice for 1.5.2, but it's not going to block.  Will take patches.

Comment 3

[Andrew Halberstadt [:ahal]]

I'll take this, I've always thought that this would be a good way to do things.  I've already renamed the 'radio' method to 'select' in my controller refactor anyway.

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - Allow radio.select on radiogroup elements

Comment 5

[Heather Arthur [:harth]]

Comment on attachment 522537 [details] [diff] [review]
Patch 1.0 - Allow radio.select on radiogroup elements

awesome!

Comment 6

[Andrew Halberstadt [:ahal]]

master: https://github.com/mozautomation/mozmill/commit/addb94a23686e118b80dd2be8b0805a576c76158