599783 - 0 points received for downloading firefox through the affiliate link

Status: VERIFIED FIXED

(Websites Graveyard :: spreadfirefox.com, defect)

Description

[Paul Craciunoiu [:paulc]]

I've been testing the affiliate links this week and, although I see downloads and visits to my link on my profile, the number of points I have is still 0.

http://www.spreadfirefox.com/user/228066

Looks like a blocker for next push, re bug 586108


Alex, any chance you can help out?

Comment 1

[Mary]

Hi guys:  Looked into this a bit.  There is something strange going on with "points".  Points should = downloads.  However, they're are three data points shown for each affiliate:

* overall clicks per button.
* overall downloads
* overall points 

The Top Fox leader board pulls the "points".  Alex:  Can you take a look at the code behind the leaderboard or point us to it to see how this is triangulated?
Thanks!

Comment 2

[Michael Morgan [:morgamic]]

Pretty sure the code is right here:
http://svn.mozilla.org/projects/spreadfirefox.com/trunk/sites/all/modules/sfx_affiliates/

See:
http://svn.mozilla.org/projects/spreadfirefox.com/trunk/sites/all/modules/sfx_affiliates/new_points_tally.php

Comment 3

[Mike Alexis [:malexis]]

Paul, hit up morgamic for any help needed debugging this.

Comment 4

[Mike Alexis [:malexis]]

Alex, Paul needs help deciphering the script you and Sam wrote for this. Can you help him debug?

This is blocking the Text links for Affiliates launch.

Comment 5

[Alex Buchanan [:abuchanan]]

(In reply to comment #4)
> Alex, Paul needs help deciphering the script you and Sam wrote for this. Can
> you help him debug?
> 
> This is blocking the Text links for Affiliates launch.

Is there specific question?  Or are you saying I need to pick up this project and debug it myself?

Comment 6

[Mike Alexis [:malexis]]

sorry for the confusion. Instead of going back and forth with Paul, I think it would make sense for you to take it.

Let us know if you need any more details or have any questions.

Comment 7

[Mary]

Alex:  Have you been able to work on this?

Thanks!

Comment 8

[Alex Buchanan [:abuchanan]]

(In reply to comment #7)
> Alex:  Have you been able to work on this?
> 
> Thanks!

I haven't sorry, but I will focus on it this week, starting today.

Comment 9

[Alex Buchanan [:abuchanan]]

Ah, I may have found the problem.  There is some code that checks if the button ID is valid before it counts the points for that button.  Since the button ID for text links is a hard-coded value, the points tally code thinks it's an invalid button ID and therefore doesn't count any points.

Still need to test and look into this more before I'm sure, but figured I should drop an update.

Comment 10

[Mary]

Thanks, dude...updates appreciated.  They make me happy.

Comment 11

[Alex Buchanan [:abuchanan]]

Looks like that was the problem.  r76472 should fix this.

Comment 12

[Mary]

YTB!

Comment 13

[Alex Buchanan [:abuchanan]]

IIRC, we don't have Affiliates tracking set up in staging, so there's nothing to test/QA at the moment.

In the past, we've kinda just crossed our fingers and put things in production.  Of course, I really don't like that.  I'm not sure yet how to set up tracking in staging for QA though, it's a pretty complex setup.  

Also, I still need to remove the reference to points in the user profiles.

Comment 14

[Alex Buchanan [:abuchanan]]

r76719 removes the "points" line from the user profile.

(In reply to comment #13)
> IIRC, we don't have Affiliates tracking set up in staging, so there's nothing
> to test/QA at the moment.
> 
> In the past, we've kinda just crossed our fingers and put things in production.
>  Of course, I really don't like that.  I'm not sure yet how to set up tracking
> in staging for QA though, it's a pretty complex setup.  
> 
> Also, I still need to remove the reference to points in the user profiles.

I have an idea for this.  I can make a form that will allow you to create some fake affiliates traffic.  That should help to test things more directly, and avoid the complex setup issues.  It will take some more time.  I'll work on it today.

Comment 15

[Mary]

Thank you - that would be very helpful!

Comment 16

[Mary]

GRACIAS!!!!

Comment 17

[Alex Buchanan [:abuchanan]]

bug 614033 pushed this fix live.  I tested over the weekend, and it seems to work for me.

Comment 18

[krupa raj[:krupa]]

verified that the points system works.

Filed bug 615302 and bug 615294