599866 - Update restart test module testMultipleExtensionInstallation to reflect the new Add-ons API

Status: RESOLVED INVALID

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Comment 1

[Aaron Train [:aaronmt]]

Attachment: WIP v1

An update on this one. I'm running into a problem before the second add-on is installed, where the test is continuing (it will restart and begin test2.js) and ignore the second countdown in the modal dialog. I'd appreciate if you ran this Henrik so you can see it.

Here is the WIP v1. Not sure what's up with that.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 480236 [details] [diff] [review]
WIP v1

While I'm checking a drive-by review...

>+++ b/firefox/restartTests/testMultipleExtensionInstallation/test1.js
[..]
> const TIMEOUT = 5000;
>-const gInstallTimeout = 10000;

Please leave the install timeout but simply reduce the time.

>+const ADDONS = [{
>+  extensionName: "DOM Inspector",
>+  extensionId: "[e-mail]",
>+  extensionURL: "https://addons.mozilla.org/en-US/firefox/addon/6622/"
>+ },{
>+  extensionName: "Mozilla QA Companion",
>+  extensionId: "{667e9f3d-0096-4d2b-b171-9a96afbabe20}",
>+  extensionURL: "https://addons.mozilla.org/en-US/firefox/addon/5428/"
>+ }

I would prefer to use ACR and QAC. Also strip the "extension" part from all keys please.

>+  for each(var addon in persisted.addons) {

persisted.addons.forEach()

>+    // Switch to the Extensions pane
>+    var category = addonsManager.getCategoryById({id: "extensions"});
>+    addonsManager.setCategory({category: category});

setCategoryById

>+    // Check some properties of the ready to be installed extension
>+    var installedAddon = addonsManager.getAddons({
>+                  attribute: "name", 
>+                  value: addon.extensionName
>+                })[0];

Please fix the indentation. Also use the guid.

>+    // Check if the restart and undo links and remove button are present
>+    // XXX: Bug 599771
>+    //var restartLink = am.getAddonLink({addon: addon, link: "restart"});
>+    //controller.assertNodeExist(restartLink);
>+    var undoLink = addonsManager.getAddonLink({
>+                     addon: installedAddon,
>+                     link: "undo"
>+                   });
>+    controller.assertNode(undoLink);

Undo is not necessary here.

>+    var removeButton = addonsManager.getAddonButton({
>+                         addon: installedAddon,
>+                         button: "remove"
>+                       });
>+    controller.assertNode(removeButton);

Same for remove.

>+  controller.assertJS("subject.extensions[0].name == subject.extensionName", {
>+    extensions: itemElem.childNodes, 
>+    extensionName: persisted.currentAddon.extensionName
>+  });

.assert please.

>-  // Will the extension be installed from https://preview.addons.mozilla.org/?
>-  var isAMOUrl = itemElem.childNodes[0].url.indexOf('preview.addons.mozilla.org') != -1;
>+  // Will the extension be installed from https://addons.mozilla.org
>+  var isAMOUrl = itemElem.childNodes[0].url.indexOf('addons.mozilla.org') != -1;
>   controller.assertJS("subject.isExtensionFromAMO == true",
>                       {isExtensionFromAMO: isAMOUrl});

Please don't change the urls. We still want to use preview.

>+++ b/firefox/restartTests/testMultipleExtensionInstallation/test2.js
[..]
>+  // Switch to the Extensions pane
>+  var category = addonsManager.getCategoryById({id: "extensions"});
>+  addonsManager.setCategory({category: category});

setCategoryById

>+  for each(var addon in persisted.addons) {

forEach again.


The reason why it stops could be the usage of 'for each'. Please replace it with forEach and test again.

Comment 3

[Aaron Train [:aaronmt]]

Attachment: WIP v2

forEach is cool, and am using it but it doesn't resolve the issue. I've spent a few hours trying to figure out what's happening on the second pass. What's happening is that on the second pass, when the software dialog comes up, the test is supposed to wait like it has on the first pass, but the test continues. I've attached the WIP, would be good if you can try it out and see.

Comment 4

[Aaron Train [:aaronmt]]

Forgot to mention, the problem will go away if you sleep before the AOM opens, so we need to wait for something to fix the issue, just not sure what to wait for.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

the patch cannot be applied cleanly. Can you please update it?

Comment 6

[Aaron Train [:aaronmt]]

Attachment: WIP v3

I've removed the opening and checking of the add-ons in the AMO for the time being, but the issue with the countdown timer still exists.

Try this out. I bet you'll know what to wait for when the install dialog comes up the second time and the test continues.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.

Comment 8

[Aaron Train [:aaronmt]]

Don't have time available to rewrite/unbitrot 4.0 addon tests. Opening up assignment.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This test has been rewritten on bug 671315 -> invalid.