599893 - configure.in: review/document when NS_ENABLE_TSF should actually be active

Status: NEW

(Core :: Widget: Win32, defect)

Description

[Serge Gautherie (:sgautherie)]

1)
I +/- read bug 509179 and it's not obvious to me why NS_ENABLE_TSF depends on '-z "$GNU_CC"'.
'"$MOZ_WINSDK_TARGETVER" -lt "06000000"' should be enough, shouldn't it?

***

2)
If the reason is related to bug 88831 comment 135 (and bug 478618), it seems the correct check should be on 'msctf.h', not (GNU_CC and/or) MOZ_WINSDK_TARGETVER.

For example, I have VS8E(2005) and PSDK2003R2:
TSF is disabled though the latter includes 'msctf.h'...

***

Ftr,
http://msdn.microsoft.com/en-us/library/ms629032.aspx
{
Text Services Framework

Text Services Framework is applicable for Windows-based computers using text services and Windows XP or later versions of the operating system.

Text Services Framework is available as a redistributable for Windows 2000.
To download the latest redistributable, go to Windows Server 2003 SP1 Platform SDK.
}

Comment 1

[Masatoshi Kimura [:emk]]

Does w32api contain msctf.h?

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)
> Does w32api contain msctf.h?

Sorry, what do you call "w32api"?

Comment 3

[Masatoshi Kimura [:emk]]

I meant to say Win32 libralies and headers for MinGW.
http://sourceforge.net/projects/mingw/files/MinGW/BaseSystem/RuntimeLibrary/Win32-API/
Mozilla requires w32api 3.8 or later for MinGW build.
http://mxr.mozilla.org/mozilla-central/search?string=w32api

Comment 4

[Masatoshi Kimura [:emk]]

> If the reason is related to bug 88831 comment 135 (and bug 478618), it seems
> the correct check should be on 'msctf.h', not (GNU_CC and/or)
> MOZ_WINSDK_TARGETVER.
See bug 509179 comment 1.

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> See bug 509179 comment 1.

"Pretty sure disabling things only based on what's available is taboo."

Then, MOZ_WINSDK_TARGETVER check should be extended to accept PSDK2003R2 too (at least), should it not?

Comment 6

[Masatoshi Kimura [:emk]]

How should I check the SDK version? Although 2003 R2 SDK contains msctf.h, 2003 SP1 SDK doesn't. Both SDKs have a common target windows version 502.