Closed
Bug 599921
Opened 15 years ago
Closed 15 years ago
Uninstalling an extension installed with a file pointer will wipe out the directory the files are in rather than just the file pointer
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla2.0b7
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | beta7+ |
People
(Reporter: mossop, Assigned: mossop)
References
Details
(Keywords: dataloss, regression)
Attachments
(1 file)
|
10.28 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
DirectoryInstallLocation.uninstallAddon should be deleting the dir/file/xpi in the install location that represents hte extension, instead it is deleting the resolved path of the extension. Regression from bug 533038
|
||
Updated•15 years ago
|
blocking2.0: --- → beta7+
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → dtownsend
|
|
||
Updated•15 years ago
|
Whiteboard: [needs patch]
|
|
Assignee | |
Comment 1•15 years ago
|
||
Straightforward patch, we should ignore the file from IDToFileMap and instead just look at the file/directory/xpi in the install location's directory and remove that.
Added a useful set of tests to verify file pointer operations.
Attachment #478845 -
Flags: review?(robert.bugzilla)
|
|
Assignee | |
Updated•15 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [needs patch] → [has patch][needs review rs]
|
||
Updated•15 years ago
|
Attachment #478845 -
Flags: review?(robert.bugzilla) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [has patch][needs review rs]
Target Milestone: --- → mozilla2.0b7
|
||
Comment 3•15 years ago
|
||
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b7pre) Gecko/20101006 Firefox/4.0b7pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•