If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Uninstalling an extension installed with a file pointer will wipe out the directory the files are in rather than just the file pointer

VERIFIED FIXED in mozilla2.0b7

Status

()

Toolkit
Add-ons Manager
--
critical
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

({dataloss, regression})

Trunk
mozilla2.0b7
dataloss, regression
Points:
---
Bug Flags:
in-testsuite +
in-litmus -

Firefox Tracking Flags

(blocking2.0 beta7+)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
DirectoryInstallLocation.uninstallAddon should be deleting the dir/file/xpi in the install location that represents hte extension, instead it is deleting the resolved path of the extension. Regression from bug 533038
(Assignee)

Updated

7 years ago
Severity: normal → critical
Keywords: dataloss
blocking2.0: --- → beta7+
(Assignee)

Updated

7 years ago
Assignee: nobody → dtownsend
Whiteboard: [needs patch]
(Assignee)

Comment 1

7 years ago
Created attachment 478845 [details] [diff] [review]
patch rev 1

Straightforward patch, we should ignore the file from IDToFileMap and instead just look at the file/directory/xpi in the install location's directory and remove that.

Added a useful set of tests to verify file pointer operations.
Attachment #478845 - Flags: review?(robert.bugzilla)
(Assignee)

Updated

7 years ago
Status: NEW → ASSIGNED
Whiteboard: [needs patch] → [has patch][needs review rs]
Attachment #478845 - Flags: review?(robert.bugzilla) → review+
(Assignee)

Comment 2

7 years ago
Landed: http://hg.mozilla.org/mozilla-central/rev/0471d08c1958
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [has patch][needs review rs]
Target Milestone: --- → mozilla2.0b7
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b7pre) Gecko/20101006 Firefox/4.0b7pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.