599956 - If Mozmill runs in debug mode the error console should be enabled

Status: VERIFIED FIXED

(Testing :: Mozbase, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

In current nightly builds on trunk the error console is disabled by default. You will have to flip a pref and restart Firefox to make the entry appear again in the tools menu. This is contrary by using Mozmill with the debug option and a fresh profile. You can't restart Firefox.

We have to add devtools.errorconsole.enabled=true to the default preferences.

Right now it's more than complicated to debug stuff with Mozmill.

Comment 1

[cmtalbert]

Let's do this when the --debug parameter is specified.  Let's see if we can take this on 1.5.1

Comment 2

[Heather Arthur [:harth]]

Attachment: enable error console in --debug mode

This will turn on the error console when --debug is specified. I should note that flipping this pref also appears to pop open the error console when the browser is started.

Comment 3

[Heather Arthur [:harth]]

Attachment: enable error console in --debug mode

that was the wrong diff. this is the right one.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 481688 [details] [diff] [review]
enable error console in --debug mode

Sorry, but I'm not a peer of jsbridge. So I will not review it. But the changes looks fine and also work as expected -> feedback+. Please ask Jeff for review.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #2)
> that flipping this pref also appears to pop open the error console when the
> browser is started.

That's what we want and which is great.

Comment 6

[cmtalbert]

Comment on attachment 481688 [details] [diff] [review]
enable error console in --debug mode

thanks!

Comment 7

[Heather Arthur [:harth]]

1.5.1:
http://github.com/mozautomation/mozmill/commit/a2e23ce0263f61265131a80d0a339e225d1be6d9

master:
http://github.com/mozautomation/mozmill/commit/5899df8d25b4304045cd790f6af8c005bb933de1

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with a Minefield build from 100921. Thanks.