Closed Bug 60005 Opened 24 years ago Closed 24 years ago

need pref ui for "browser.chrome.toolbar_tips"

Categories

(SeaMonkey :: Preferences, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.0

People

(Reporter: sspitzer, Assigned: bugzilla)

Details

Attachments

(2 files)

thanks to pink, "browser.chrome.toolbar_tips" works.

no we need some pref ui to turn it on and off.
a checkbox in the Navigator panel would seem a logical place, but it's rather
crowded these days. *sigh* how about the Appearance panel?

other folx: your thoughts on this?
actually, if we wished to follow the 4.x example, then this pref would show up
in the Appearance panel. [then again, the toolbar pref ui is currently in the
Navigator panel --in 4.x it was also in Appearance, i'll need to dig around to
see if there's been a bug of some sort asking to move the toolbar stuff to a
more appropriate place. *shrug*]
delegating appropriately (really, this should go to the UE person for prefs)
Assignee: alecf → matt
Summary: need ui for "browser.chrome.toolbar_tips" → need pref ui for "browser.chrome.toolbar_tips"
I suggest a `Show Tooltips'/`Hide Tooltips' item at the top of the `Help' menu. 
On Mac we could use the currently useless `Show Balloons'/`Hide Balloons' menu 
item, though that would require a bit more work on Pink's part. :-)
Hardware: PC → All
i don't believe we can intercept the System items in the help menu for our own
use. As with our troubles with submenus in help, the OS just doesn't tell us
when certain things are done in the help menu.
I have *never* seen a Help menu in Windows with a checkbox menu item.
Ok Mike, how hard would it be to attack the problem from the other end, and show 
tooltip content as help balloons instead (when `Show Balloons' is selected)? The 
tooltip text wouldn't be ideal as help balloon text, but it would be a start. 
(Tooltips on Windows could show the value of the `title' attribute of a control, 
while help balloons on Mac showed the value of the `title' attribute plus the 
value of a `summary' attribute which could be added later.)

Blake, this wouldn't be a checkbox item, it would be a toggle between `Show 
Tooltips' and `Hide Tooltips' -- like the toggle between `Show the Office 
Assistant' and `Hide the Office Assistant' in the `Help' menu of Office 2000.
given that tooltips can contain any arbitrary data (defined by the package that
creates them), macOS tooltips aren't sufficient. Sure, they are _now_ but if ben
wants to add something cool like thumbnail images of the page you'll visit when
hovering over a link (to pull something out of my ass), the other platforms will
get it and mac won't.

I think this is a dead end, lets try to find another way to set this pref.
The main appearance pref pane has room, can't we just add it there?
I agree with mcafee; add it to the appearance panel as in 4.x.  Doesn't this
pref actually apply to more than the browser tooltips?  Or do we need to create
prefs for each app (composer, mail, news, etc.)?

Here is a related comment from Jason Alcock (11/15/2000) at
http://www.macintouch.com/netscape6.html:

I have yet to find a way to turn off tooltips in the UI.
Keywords: nsmac2
taking
Assignee: matt → blakeross
Target Milestone: --- → mozilla1.0
Status: NEW → ASSIGNED
I'm gonna do this now...can anyone give me proper wording/design to use?  I 
planned on mimicking 4.x (assuming it was competent), but win32 4.76 doesn't 
seem to have a way to turn tooltips on and off from the prefs dialog.
I'll post a screen shot of the 4.x linux ui for this.
looking at the 4.x ui, I would keep the "Show Tooltips" wording and have it in
the "Appearance" panel, but don't leave it in the "Show Toolbar As" box, if we
have one in 6.x
Yeah. It seems weird to have the checkbox outside any group.  Matthew, is this 
the right thing to do?
Putting it in the `Show Toolbars As' titledbox makes some sense, given that if 
you show text for the toolbar buttons you probably won't want tooltips, and if 
you have only pictures for toolbar buttons you probably will want tooltips. But 
that wouldn't work if we split toolbar customization off into its own dialog 
(as we probably should), since not all tooltips are for toolbars.

So short of having a separate `Tooltips' titledbox with a single checkbox in 
it, I don't know how you could present this nicely -- you're right that having 
this checkbox outside a titledbox, when all the other controls are in a 
titledbox, would look odd.

'Course, I still maintain that the appropriate UI for this is no UI at all. :-)
...Is this really just to show/hide tooltips in toolbars, or everywhere?  This 
pref is badly named (even if it is just for toolbars, it's not specific to 
browser)

I don't really see how it belongs in the Show Toolbars As group, so unless 
anyone has any better ideas (short of just not having UI for it :-), I'll just 
leave it floating outside a group...
cc'ing alec for sr
sr=alecf
r=timeless, although i think tooltips should have some sort of groupbox title. 
we can do that later.
Keywords: patch
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reopening for hygenic reasons. The array

   ["generalStartupBrowser", /*"toolbarStyle" */, "showHideTooltips"]

has length 3, with the value of second element being 'undefined'. 

This leads to the (intentionally) whining error message:
  "*** FIX ME: '_elementIDs' in 'pref-appearance.xul' contains a reference 
   to a non-existent element ID 'undefined'." 

Stick the commented-out element at the end of the array (or include the comma
inside the comment).
oops!  Thanks.
Status: REOPENED → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
Thanks for cleaning that one point up. (I do agree with timeless that a 
titledbox around that lone checkbox would be nice, but otherwise this bug
is done). 
'Course, the quarterbacks amongst us want to know why neither the reviewer nor 
the super-reviewer spotted that array bug in a ten-line patch ...
cuz it was a comma after a comment? get a freakin life.
I don't see you reviewing, or even writing any code for that matter.
You can nit-pick me as soon as I see one of these things from you.
Since I do write code, can I make a really minor nit-pick?  The label shouldn't
have a period at the end of it.
I agree about the extra ".", since none of the other labels have them.

I've removed it.
vrfy fixed using 2001.02.09.0x comm bits on linux, mac and winnt.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: