Closed
Bug 600066
Opened 14 years ago
Closed 14 years ago
mochitest-chrome: don't use octal escape sequences in chrome-harness.js
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla2.0b7
People
(Reporter: zpao, Assigned: zpao)
References
Details
Attachments
(1 file)
|
2.30 KB,
patch
|
cmtalbert
:
review+
|
Details | Diff | Splinter Review |
I'm getting tired of seeing this with every single mochitest:
JS Component Loader: WARNING chrome://mochikit/content/chrome-harness.js:278
octal literals and octal escape sequences are deprecated
It's not only a bit annoying, but is also causing untold amounts of bloat to the logs.
I think it's only an issue with debug builds since those run in strict mode.
|
Assignee | |
Comment 1•14 years ago
|
||
This just fixes the ones that cause spew at every test. There are a couple warnings coming from server.js, but those only happen once when the component is loaded, not at the beginning of every test.
Assignee: nobody → paul
Status: NEW → ASSIGNED
Attachment #478912 -
Flags: review+
|
||
Comment 2•14 years ago
|
||
See also bug 532369 for server.js.
|
|
Assignee | |
Comment 3•14 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/afa0a8afbee0
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Summary: Don't use octal escape sequences in mochitest → Don't use octal escape sequences in mochitest harness
Target Milestone: --- → mozilla2.0b7
|
||
Updated•14 years ago
|
Component: Mochitest → Chrome
Flags: in-testsuite-
QA Contact: mochitest → chrome
Summary: Don't use octal escape sequences in mochitest harness → mochitest-chrome: don't use octal escape sequences in chrome-harness.js
Version: unspecified → Trunk
|
|
Assignee | |
Comment 5•14 years ago
|
||
This was backed out (bad merge?) in http://hg.mozilla.org/mozilla-central/diff/7e4f8cb08cba/testing/mochitest/chrome-harness.js (bug 543800). I'll re-land today.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 6•14 years ago
|
||
Re-landed http://hg.mozilla.org/mozilla-central/rev/91a49bf6464b
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: Mochitest Chrome → Mochitest
You need to log in
before you can comment on or make changes to this bug.
Description
•