600094 - last page visited should allow for chrome: or about: local pages

Status: VERIFIED FIXED

(Input :: General, defect, P2)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Mozilla/5.0 (Maemo;Linux armv71; rv:2.0b7pre)Gecko/20100927 Firefox/4.0b7pre Fennec/2.0b1pre

Mozilla/5.0 (Android; Linux armv71; rv2.0b7pre) Gecko/20100927 Firefox/4.0b7pre Fennec/2.0b1pre

1. goto about:firstrun
2. go to the control panel
3. select the beta icon
4. select happy face
5. type in the text
6. select the add URL of last visited page checkbox
7. click the submit Feedback button

Expected: webpage would submit
Actual: Enter a valid URL.

Note:
1. suggestion to add local pages if the user wants to submit feedback on the about: or the chrome: pages.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Did not mean to include android.  Meant Mac Os X:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b7pre) Gecko/20100927 Firefox/4.0b7pre Fennec/2.0b1pre

Comment 2

[Aakash Desai [:aakashd]]

I'll look into this and see if it really is an Input bug. There might be an issue around the function call in MobiFx's feedback add-on to POST the URL to our submission pages.

Comment 3

[Fred Wenzel [:wenzel]]

Yea, Input uses a Django URLfield for this, which checks for valid HTTP(S) URLs. So about:blank and friends are not currently accepted.

Comment 4

[Aakash Desai [:aakashd]]

We should accept anything starting with "about:" as there are a number of pages that users will see with firefox 4 (i.e. about:addons) that will be related to bugs.

Comment 6

[Fred Wenzel [:wenzel]]

I had to mess with the URL validator to get about: and chrome:// URLs to be accepted as well.

http://github.com/fwenzel/reporter/commit/7ff5c90

This contains multiple unit tests, both for the validator accepting such URLs as well as the view itself accepting the submission.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED:

http://input.stage.mozilla.com/en-US/opinion/637601 (chrome: URL)
http://input.stage.mozilla.com/en-US/opinion/637599 (about: URL)

In-litmus- because this has unit tests (thanks, Fred!!)