Closed
Bug 600195
Opened 14 years ago
Closed 14 years ago
MSVC chokes on valgrind headers w/ NVALGRIND defined
Categories
(Tamarin Graveyard :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: treilly, Assigned: treilly)
References
Details
Attachments
(1 file)
|
1.61 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•14 years ago
|
||
c:\buildbot\tamarin-redux\windows\repo\mmgc\GCObject.h(478) : error C2958: the left parenthesis '(' found at 'c:\buildbot\tamarin-redux\windows\repo\mmgc\gcobject.h(478)' was not matched correctly
c:\buildbot\tamarin-redux\windows\repo\mmgc\GCObject.h(478) : error C2059: syntax error : ')'
c:\buildbot\tamarin-redux\windows\repo\mmgc\GCObject.h(478) : error C2059: syntax error : ')'
c:\buildbot\tamarin-redux\windows\repo\mmgc\GCObject.h(479) : error C2059: syntax error : 'return'
c:\buildbot\tamarin-redux\windows\repo\mmgc\GCObject.h(479) : error C2238: unexpected token(s) preceding ';'|
|
Assignee | |
Comment 2•14 years ago
|
||
Ex, this:
VALGRIND_MAKE_MEM_DEFINED(c, sizeof(c));
compiles to:
(({unsigned long _qzz_res; { (_qzz_res) = (0); }; _qzz_res; }));
MSVC doesn't like the paren's, removing them makes it compile.|
|
Assignee | |
Comment 3•14 years ago
|
||
Assignee: nobody → treilly
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•14 years ago
|
||
Fix folded into here: http://hg.mozilla.org/tamarin-redux/rev/55df5da12f64
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•