MSVC chokes on valgrind headers w/ NVALGRIND defined

RESOLVED FIXED

Status

Tamarin
Build Config
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Tommy Reilly, Assigned: Tommy Reilly)

Tracking

(Blocks: 1 bug)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

8 years ago
c:\buildbot\tamarin-redux\windows\repo\mmgc\GCObject.h(478) : error C2958: the left parenthesis '(' found at 'c:\buildbot\tamarin-redux\windows\repo\mmgc\gcobject.h(478)' was not matched correctly
c:\buildbot\tamarin-redux\windows\repo\mmgc\GCObject.h(478) : error C2059: syntax error : ')'
c:\buildbot\tamarin-redux\windows\repo\mmgc\GCObject.h(478) : error C2059: syntax error : ')'
c:\buildbot\tamarin-redux\windows\repo\mmgc\GCObject.h(479) : error C2059: syntax error : 'return'
c:\buildbot\tamarin-redux\windows\repo\mmgc\GCObject.h(479) : error C2238: unexpected token(s) preceding ';'
(Assignee)

Updated

8 years ago
Blocks: 509020
(Assignee)

Comment 2

8 years ago
Ex, this:
            VALGRIND_MAKE_MEM_DEFINED(c, sizeof(c));
compiles to:
            (({unsigned long _qzz_res; { (_qzz_res) = (0); }; _qzz_res; }));

MSVC doesn't like the paren's, removing them makes it compile.
(Assignee)

Comment 3

8 years ago
Created attachment 479047 [details] [diff] [review]
manually short circuit valgrind macros
Assignee: nobody → treilly
Status: NEW → ASSIGNED
(Assignee)

Comment 4

8 years ago
Fix folded into here: http://hg.mozilla.org/tamarin-redux/rev/55df5da12f64
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.