600218 - Remove MSVC6 support from MozillaBuild

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[Mitchell Field [:Mitch]]

Building any currently-active Mozilla branch with MSVC6 is impossible. We should nuke anything specific to MSVC6.

Comment 1

[Mitchell Field [:Mitch]]

Attachment: Patch

Comment 2

[Justin Wood (:Callek)]

iirc, Neil still builds Mozilla *trunk* with MSVC6 on some system, with a few local hacks. I'm not sure the benefit to removing the little support in MozBuild is really high on our list.

Comment 3

[[e-mail]]

(In reply to comment #2)
> iirc, Neil still builds Mozilla *trunk* with MSVC6 on some system, with a few
> local hacks. I'm not sure the benefit to removing the little support in
> MozBuild is really high on our list.
It's not MSVC6 any more, and I'm not using MozillaBuild for it anyway.

How do the Wiki docs suggest building 1.8.x and earlier?

Comment 4

[(not currently active) Ted Mielczarek]

Doesn't really matter, they're unsupported branches, and old versions of MozillaBuild are still available on FTP if need be. (The current version still contains this code, so it wouldn't be until the next release that people would have a problem anyway.)

Callek: it may not be high on our list, but if Mitch wants to patch it that's fine with me.

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 479065 [details] [diff] [review]
Patch

Please remove the MSVC6 lines from guess-msvc.bat while you're at it.

Comment 6

[Mitchell Field [:Mitch]]

http://hg.mozilla.org/mozilla-build/rev/bbc637f57f4d

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Pushed http://hg.mozilla.org/mozilla-build/rev/b91f3a86c79b to make mozilla-build actually build again.