600288 - Need to click "Sync Now" twice in notification error to activate

Status: RESOLVED WORKSFORME

(Firefox :: Sync, defect)

Description

[Tony Chung [:tchung]]

When sync fails, the Sync Now button appears in the new notification status bar.  However, i need to click the Sync Now button TWICE, before anything actually happens.

Repro:
1) install nightly: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b7pre) Gecko/20100926 Firefox/4.0b7pre
2) log into sync account, but find a way to create a sync server error.  (in my case, db29 is down so its easy to simulate)
3) When the sync now notification error appears, click "Sync Now"
4) Verify the first Click does nothing.  Only on second click does sync now, try to initiate a server connection

Expected:
- click sync now once, not twice, should initiate the connection

Actual:
- click twice

Comment 1

[Allison Naaktgeboren :ally]

I do not think this is still a valid bug. It dates from ffx4, and we have instant sync now (though we still have not removed the 'Sync Now' menu entry.

Connor, I'm inclined to close this. Thoughts?

Comment 2

[Josh Matthews [:jdm]]

This isn't about the menu entry, this is about the notification bar that pops up when an error occurs. Closing this wouldn't make the problem described in comment 0 go away.

Comment 3

[Tracy Walker [:tracy]]

Logs confirm that, first click of the notification bar Sync Now button does trigger a sync, which also fails and triggers the same notification bar and Sync Now button.  Another click of the Sync now button fires the notification bar and Server Status button.  iirc, this is all intended behavior.