600300 - Save helper app downloads to downloads directory on Android and Maemo

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Android stock browser saves everything to downloads directory. We currently save downloaded files there, but files opened with helper apps are saved in the temp directory. We should match the android browser behavior.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch from Bug 596370

Patch from Bug 596370.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 479127 [details] [diff] [review]
Patch from Bug 596370

This patch should make Fennec work like the Android browser regarding file download locations and only downloading to the /sdcard

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Let's make sure we get this behavior in for b2

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mozilla-central/rev/122f096c90c2

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified:
Mozilla/5.0 (Android; Linux armv71; rv2.0b8pre) Gecko/20101018 Firefox/4.0b8pre Fennec/4.0b2pre

Note to tester (from wesj): 
app helper is defined as anything that automatically gets opened by an external application.  in fennec, that's everything except for downloads that you long click on and pick "Save Link" from the context menu.

ie. like a short tap on a pdf file as long as there is a pdf reader installed should show this.

Comment 6

[Ayan Shah[:ashah]]

https://litmus.mozilla.org/show_test.cgi?id=13818

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

A followup patch was pushed:
http://hg.mozilla.org/mozilla-central/rev/1a55741b7b27

which started burning the Maemo trees. The MAEMO code was never getting compiled and now that it is, it's burning. Fix coming up.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: bustage fix for Maemo

Bustage fix