600408 - Fix crashreporter launching code to launch correct architecture on OS X 10.5

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[(not currently active) Ted Mielczarek]

Similarly to bug 600362, when we launch the crash reporter client after a crash, we just use fork() / exec(). This will result in the x86-64 crashreporter binary being launched, which is not likely to work well on 10.5.

Comment 1

[(not currently active) Ted Mielczarek]

The code that launches the crashreporter is here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/nsExceptionHandler.cpp#420

We currently share the same codepath for all XP_UNIX.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Doesn't this need to block b7?

Comment 3

[(not currently active) Ted Mielczarek]

Yeah, sorry, it was getting late and I forgot to request blocking. Without fixing this, crash reporting probably won't work at all on 10.5.

Comment 4

[Josh Aas]

Ted has kindly volunteered to look at this.

Comment 5

[(not currently active) Ted Mielczarek]

Attachment: Fix crashreporter launching code to launch correct architecture on OS X 10.5

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 480178 [details] [diff] [review]
Fix crashreporter launching code to launch correct architecture on OS X 10.5

This fixes both launching the crash reporter client and restarting the app from the client. I tested on 10.6 by running the app as a 64-bit process, crashing, verifying that crashreporter was 64-bit, restarting, verifying that Firefox was 64-bit, then repeating the process but running with "arch -arch i386" to make the initial process 32-bit.

Comment 7

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/c96f0f84c540